[21387] Improve Windows merge meta files action #116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
JesusPoderoso
force-pushed
the
hotfix/21307
branch
from
20cf85e to
a7c3c59
Compare
JesusPoderoso
changed the title
JesusPoderoso
force-pushed
the
hotfix/21307
branch
from
18b7112 to
32b06a1
Compare
Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>
…con meta arg Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>
JesusPoderoso
force-pushed
the
hotfix/21307
branch
from
32b06a1 to
cff248e
Compare
5 tasks
MiguelCompany
approved these changes
Jul 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The windows merge meta files action was only considering that the initial lines of the merged metas should be discarded, but it is not scalable.
This PR introduces a Yaml parser in the action that parses the file, eliminates possible duplicated arguments and condenses properly all arguments under the corresponding packages.
Contributor Checklist
versions.mdandREADME.mdfiles (if applicable).Reviewer Checklist