Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[21387] Improve Windows merge meta files action #116

Merged
merged 2 commits into from
Jul 22, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -157,11 +157,6 @@ For more information about versioning handle of this project, check following [f
- [setup_python_venv](ubuntu/setup_python_venv/action.yml)
- Setup a Python virtual environment and add it to the PATH.

### Windows

- [merge_yaml_metas](windows/merge_yaml_metas/action.yml)
- Merge a set of yaml meta files into a single meta file

### macOS

- [install_brew_packages](macos/install_brew_packages/action.yml)
Expand Down
3 changes: 3 additions & 0 deletions versions.md
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,9 @@ The [Forthcoming](#forthcoming) section includes those features added in `main`

The upcoming release will include the following **features**:

- Fix the windows action colcon build to accept multiple colcon meta files.
- Remove the windows action merge yaml meta files.

## v0.23.0

- Check if python venv already exists in `setup_python_venv` action.
Expand Down
21 changes: 4 additions & 17 deletions windows/colcon_build/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,9 @@ description: Use colcon build command to build multiple packages
inputs:

colcon_meta_file:
description: colcon.meta file to set cmake options. If empty, it uses an empty file
description: colcon.meta file to set cmake options. If empty, it uses a non-existing file
required: false
default: ''
default: '__invalid.meta'

colcon_build_args:
description: Arguments to pass to colcon build command (use cmake_args input for CMake options)
Expand Down Expand Up @@ -57,14 +57,7 @@ runs:
${{ inputs.workspace_dependencies }}/setup.ps1
}

if ([string]::IsNullOrEmpty("${{ inputs.colcon_meta_file }}")) {
New-Item -ItemType File "${{ inputs.workspace }}\colcon.meta"
$env:COLCON_BUILD_META_ = "${{ inputs.workspace }}\colcon.meta"
} else {
$env:COLCON_BUILD_META_ = "${{ inputs.colcon_meta_file }}"
}

echo "Using colcon.meta file <$env:COLCON_BUILD_META_>"
echo "Using colcon.meta file(s) <${{ inputs.colcon_meta_file }}>"

cd ${{ inputs.workspace }}

Expand All @@ -77,16 +70,10 @@ runs:
-StartInPath (pwd) -DevCmdArguments '/arch=x64 /host_arch=x64'

colcon build `
--metas $env:COLCON_BUILD_META_ `
--metas ${{ inputs.colcon_meta_file }} `
${{ inputs.colcon_build_args_default }} `
${{ inputs.colcon_build_args }} `
--cmake-args `
-DCMAKE_BUILD_TYPE=${{ inputs.cmake_build_type }} ${{ inputs.cmake_args_default }} ${{ inputs.cmake_args }}

cd -

if ([string]::IsNullOrEmpty("${{ inputs.colcon_meta_file }}")) {
Remove-Item -Path "${{ inputs.workspace }}\colcon.meta"
}

"::endgroup::"
43 changes: 0 additions & 43 deletions windows/merge_yaml_metas/action.yml

This file was deleted.