[20108] Clarify Fast DDS Discovery Server Tutorial for Windows support #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elianalf
suggested changes
Dec 11, 2023
|
|
||
| .. code-block:: console | ||
|
|
||
| set export ROS_DISCOVERY_SERVER=127.0.0.1:11811 |
There was a problem hiding this comment.
I think this should be set ROS_DISCOVERY_SERVER=127.0.0.1:11811
There was a problem hiding this comment.
Suggested change
| set export ROS_DISCOVERY_SERVER=127.0.0.1:11811 | |
| set ROS_DISCOVERY_SERVER=127.0.0.1:11811 |
fujitatomoya
suggested changes
Dec 11, 2023
|
|
||
| .. code-block:: console | ||
|
|
||
| set export ROS_DISCOVERY_SERVER=127.0.0.1:11811 |
There was a problem hiding this comment.
Suggested change
| set export ROS_DISCOVERY_SERVER=127.0.0.1:11811 | |
| set ROS_DISCOVERY_SERVER=127.0.0.1:11811 |
Sure, thanks @fujitatomoya! |
JesusPoderoso
force-pushed
the
rolling
branch
from
0a4f76c to
e2dfd79
Compare
…upport Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>
Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>
Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>
JesusPoderoso
force-pushed
the
hotfix/windows_support_ds
branch
from
e51e4cd to
d84c044
Compare
Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>
JesusPoderoso
force-pushed
the
hotfix/windows_support_ds
branch
from
ebbb12e to
c7317be
Compare
elianalf
approved these changes
Dec 12, 2023
JesusPoderoso
added a commit
that referenced
this pull request
Dec 13, 2023
* Refs #20108: Clarify Fast DDS Discovery Server Tutorial for Windows support Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com> * Refs #20108: Remove left code Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com> * Refs #20108: Apply Linux-Windows tabs to remain file sections Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com> * Refs #20108: Fix identation and apply tabs in synced remain sections Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com> --------- Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: