Clarify Fast DDS Discovery Server Tutorial for Windows support #4063
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Refs #20108: Clarify Fast DDS Discovery Server Tutorial for Windows support Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com> * Refs #20108: Remove left code Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com> * Refs #20108: Apply Linux-Windows tabs to remain file sections Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com> * Refs #20108: Fix identation and apply tabs in synced remain sections Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com> --------- Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>
fujitatomoya
approved these changes
Dec 13, 2023
|
Hello @clalancette and @audrow, I've been following the progress of the Fast DDS Discovery Server tutorial improvements with great interest, and I noticed PR #4063 by @JesusPoderoso seems to be a valuable addition for Windows users. I believe this PR would help many users, including myself, to better understand and implement the Fast DDS Discovery Server on Windows. If possible, could you please review this PR at your earliest convenience? Thank you for your hard work and dedication to improving the ROS 2 documentation. |
clalancette
requested changes
Dec 20, 2023
source/Tutorials/Advanced/Discovery-Server/Discovery-Server.rst
Outdated
Show resolved
Hide resolved
source/Tutorials/Advanced/Discovery-Server/Discovery-Server.rst
Outdated
Show resolved
Hide resolved
Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>
clalancette
added
the
backport-all
clalancette
approved these changes
Dec 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces group tabs for
LinuxandWindowsregardingexport(linux command) andset(windows command) for environment variables in the Fast DDS Discovery Server tutorial. Fork PR:It fixes: