Skip to content
This repository has been archived by the owner on Apr 20, 2023. It is now read-only.

Update buildkit #46

Merged
merged 128 commits into from
Jul 7, 2021
Merged

Update buildkit #46

merged 128 commits into from
Jul 7, 2021

Conversation

alexcb
Copy link

@alexcb alexcb commented Jul 6, 2021 •
edited
Loading

here's an example of earthly working against this branch: earthly/earthly#1086

thaJeztah and others added 30 commits March 29, 2021 13:17
@thaJeztah
Remove duplicate "not found" from some error messages
b81b56e 
I noticed this when building a Dockerfile that failed because a file didn't
exist, so went through error messages that looked like they had a duplicate
"not found" in the output;

    [+] Building 0.9s (6/9)
     => [internal] load build definition from Dockerfile                0.2s
     => => transferring dockerfile: 306B                                0.0s
     => [internal] load .dockerignore                                   0.1s
     => => transferring context: 2B                                     0.0s
     => [internal] load metadata for docker.io/library/alpine:latest    0.0s
     => CACHED [1/5] FROM docker.io/library/alpine                      0.0s
     => [internal] load build context                                   0.6s
     => => transferring context: 701B                                   0.5s
     => ERROR [2/5] ADD no-such-file.txt /                              0.0s
    ------
     > [2/5] ADD no-such-file.txt /:
    ------
    failed to compute cache key: "/no-such-file.txt" not found: not found

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@tonistiigi
git: support subdir component
3bdb6b5 
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
@sschaap
Update SSH agent socket handling to support Windows OpenSSH using nam…
dbbe65b 
…ed pipes.

Signed-off-by: Siebe Schaap <siebe@digibites.nl>
@sschaap
Update Windows named pipe handling for SSH forwarding to use x/sys/wi…
146ea46 
…ndows rather than syscall.

Signed-off-by: Siebe Schaap <siebe@digibites.nl>
@sschaap
Rename SSH agent forwarding helper parsePlatformSocketPath() to getWi…
f3bdb4a 
…ndowsPipeDialer().

Signed-off-by: Siebe Schaap <siebe@digibites.nl>
@sschaap
Fix regular expression to test for Windows named pipe in SSH agent pa…
c9a5f88 
…th; allowed backslashes in host.

Signed-off-by: Siebe Schaap <siebe@digibites.nl>
@thaJeztah
update to go 1.16
22dd74a 
This updates all occurrences of Go 1.13 to Go 1.16; also updated
the code that's used to redact credentials in URLs to use the Go
implementation.

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@tonistiigi
Merge pull request moby#2127 from sschaap/feature/windows-openssh
0c13337 
Support for Windows OpenSSH agent forwarding
@thaJeztah
go.mod: update docker and docker cli to v20.10.7
89f23a8 
- pkg/signal: ignore SIGURG on all platforms
- pkg/archive: use v2 capabilities in layer archives
- update ishidawataru/sctp to fix possible socket leak when bind fails

docker/cli:

- config: print deprecation warning when falling back to ~/.dockercfg

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@tonistiigi
Merge pull request moby#2149 from thaJeztah/update_docker
8e88c5d 
go.mod: update docker and docker cli to v20.10.7
@tonistiigi
hack: update proto generators for arm64
33af267 
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
@tonistiigi
test: fix mirror cache handling
19453d5 
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
@tonistiigi
cache: fix possible nil dereferences
167e0dc 
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
@AkihiroSuda
Merge pull request moby#2156 from tonistiigi/nil-deref-fix
d458fb3 
cache: fix possible nil dereferences
@AkihiroSuda
Merge pull request moby#2116 from tonistiigi/git-subdir
817955d 
git: support subdir component
@AkihiroSuda
Merge pull request moby#2154 from tonistiigi/arm64-proto
04be2c3 
hack: update proto generators for arm64
@AkihiroSuda
Merge pull request moby#2155 from tonistiigi/mirror-fix
67953d6 
test: fix mirror cache handling
@thaJeztah
move RegistryConfig to resolver package
12c9920 
This allows using the resolver package without having to import
the buildkit daemon configuration.

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@tonistiigi
Merge pull request moby#2151 from thaJeztah/move_config_opt
884578f 
move RegistryConfig to resolver package
@tonistiigi
Merge pull request moby#2144 from thaJeztah/bump_golang
03af083 
update to go 1.16
@tonistiigi
vendor: fix broken gosum
a53e054 
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
@thaJeztah
Merge pull request moby#2160 from tonistiigi/fix-gosum
7e4e676 
vendor: fix broken gosum
@tonistiigi
add hack/shell helper for dev shell environment
d44a406 
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
@tonistiigi
session: make sure all token request keep correct context
53e7116 
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
@tonistiigi
filesync: ensure sendclose is always called
ce27b7e 
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
@AkihiroSuda
Merge pull request moby#2159 from tonistiigi/hack-shell
8993c69 
add hack/shell helper for dev shell environment
@ktock
Enable stargz snapshotter to use session for snapshot auth
1764b3b 
Signed-off-by: ktock <ktokunaga.mail@gmail.com>
@jedevc
Implement low-level parser primitives for heredocs
aed6932 
This provides the basic functionality for the parser to recognize and
parse provided heredocs in supported commands.

Signed-off-by: Justin Chadwell <me@jedevc.com>
@jedevc
Add support for parsing heredocs in ADD/COPY and RUN
c362e15 
Signed-off-by: Justin Chadwell <me@jedevc.com>
@jedevc
Integrate heredoc support into ADD/COPY and RUN
de7fcce 
This modifies the command structures to support inline files, as well as
provides the logic to compile them down into appropriate LLB
definitions.

Signed-off-by: Justin Chadwell <me@jedevc.com>
tonistiigi and others added 24 commits June 29, 2021 21:33
@tonistiigi
Merge pull request moby#2209 from jedevc/dockerfile-heredocs-onbuild
921b0de 
Add support for heredocs in the ONBUILD command
@AkihiroSuda
Merge pull request moby#2081 from tonistiigi/local-differ-none
be8ab28 
Allow none differ on local source to avoid false Dockerfile matches
@tonistiigi
progressui: print logs for failed step as summary in plain mode
600d283 
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
@tonistiigi
grpcerrors: avoid rpc error wrapping in error messages
460ba75 
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
@tonistiigi
exec: improve error message on exec errors
a27d7c3 
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
@AkihiroSuda
Merge pull request moby#2215 from tonistiigi/improve-errors
8d70a9e 
Improve build errors and remove useless grpc prefix
@AkihiroSuda
Merge pull request moby#2214 from tonistiigi/plain-error-logs
edc28d1 
progressui: print logs for failed step as summary in plain mode
@jedevc
Improve heredoc parsing to allow more generic words
ec1bfc8 
Previously, heredoc names were restricted to simple alphanumeric
strings. However, heredocs should support much more complex use-cases,
including quoting anywhere, as well as allowing special symbols like `.`
for easily expressing file extensions.

This patch adds support for these more complex cases, by using the shell
lexer to parse each heredoc name. Additionally, we include improvements
to the lexer to optionally preserve escape tokens to avoid problems when
lexing words that have already been lexed before.

Signed-off-by: Justin Chadwell <me@jedevc.com>
@jedevc
Improve progress and history messages for heredoc-related commands
c99b558 
Signed-off-by: Justin Chadwell <me@jedevc.com>
@sipsma
Remove unneeded Finalize method from ImmutableRef.
b85ef15 
Finalize was only used outside the cache package in one place, which
called it with the commit arg set to false. The code path followed
when commit==false turned out to essentially be a no-op because
it set "retain cache" to true if it was already set to true.

It was thus safe to remove the only external call to it and remove it
from the interface. This should be helpful for future efforts to
simplify the equal{Mutable,Immutable} fields in cacheRecord, which exist
due to the "lazy commit" feature that Finalize is tied into.

Signed-off-by: Erik Sipsma <erik@sipsma.dev>
@tonistiigi
Merge pull request moby#2213 from jedevc/dockerfile-heredoc-parsing
5840ec0 
Improve heredoc parsing to allow more generic shell-words
@tonistiigi
Merge pull request moby#2201 from jedevc/dockerfile-heredocs-progress
521727e 
Improve progress and history messages for heredoc-related commands
@tonistiigi
Merge pull request moby#2216 from sipsma/cleancache
7d38666 
Remove unneeded Finalize method from ImmutableRef.
@sipsma
Fix ref leak if fileop ref fails to mount.
f360472 
Signed-off-by: Erik Sipsma <erik@sipsma.dev>
@sipsma
Merge pull request moby#2217 from sipsma/fileop-ref-leak
3c4f737 
Fix ref leak if fileop ref fails to mount.
@tonistiigi
Merge pull request moby#2047 from thaJeztah/improve_errors
f5c34a0 
Remove duplicate "not found" from some error messages
@AkihiroSuda
Merge pull request moby#2182 from tonistiigi/seek-radix
9cf28dc 
contenthash: use SeekLowerBound to seek radix tree
@AkihiroSuda
Merge pull request moby#2163 from tonistiigi/detect-otel-env
1a7543a
@tonistiigi
enable riscv64 build
05ac5df 
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
@tonistiigi
Merge pull request moby#2222 from tonistiigi/riscv
4f9ea01 
enable riscv64 build
@crazy-max
Update QEMU emulators
9825801 
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
@tonistiigi
Merge pull request moby#2225 from crazy-max/binfmt-6.0.0
5fc0b3c 
Update QEMU emulators
@alexcb
Merge branch 'moby-master' into update-buildkit
d199faa
@alexcb
fixes to work with buildkit master
bc866a4
@alexcb alexcb marked this pull request as ready for review July 6, 2021 23:41
@alexcb alexcb requested a review from vladaionescu July 6, 2021 23:44
@alexcb alexcb mentioned this pull request Jul 6, 2021
Merged
@alexcb alexcb merged commit 467c8f2 into earthly-main Jul 7, 2021
@alexcb alexcb deleted the update-buildkit branch July 7, 2021 02:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@vladaionescu vladaionescu vladaionescu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.