Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor update #64

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

Conversation

guillaume-sainthillier
Copy link
Contributor

improve code quality and CI workflows

@BolZer
Copy link
Member

BolZer commented Oct 19, 2024

@guillaume-sainthillier Thank your for opening the PR. However the PR is quite large and some of the changes are... quite drastic. Why change the CI pipeline? And an minor update pr with about 4k lines removed :)? Maybe we can shrink the PR and split it into more PRs which are easier to review. Could you open a discussion in this repository for the CI-Pipeline changes? What are the benefits and so. :)

@guillaume-sainthillier
Copy link
Contributor Author

guillaume-sainthillier commented Oct 21, 2024

Hello @BolZer, i've split this PR into 2 more by adding #65 and #66.
Will rebase this branch once you decide to merge them (or not).

Thanks,
Guillaume

@BolZer
Copy link
Member

BolZer commented Oct 25, 2024

Hello @BolZer, i've split this PR into 2 more by adding #65 and #66. Will rebase this branch once you decide to merge them (or not).

Thanks, Guillaume

Thanks @guillaume-sainthillier. That's much better to understand. We'll continue the discussion in the remaining PRs. The PR with the PHPStan modifications is already merged. Thank you :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants