Ci improvements #66
Open
Ci improvements #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guillaume-sainthillier
force-pushed
the
ci-improvements
branch
2 times, most recently
from
4dbd3a4
to
7c8fff2
Compare
Open
|
@guillaume-sainthillier Thank you for opening the PR; the tooling looks very interesting! I noticed you mentioned encountering an issue with jms/serializer. The commit message here indicates that updating JMS addresses this. Could you provide more details about the specific issue you encountered? |
|
Hello @BolZer, tests are simply not passing with jms/serializer 3.16. There is a bug they solved starting from 3.18 (schmittjoh/serializer#1417) |
guillaume-sainthillier
force-pushed
the
ci-improvements
branch
from
7c8fff2
to
e3e2168
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Advantages to switch on laminas in CI:
A bug was spotted with jms/serializer starting from 3.16 which was not covered when keeping a composer.lock file