Fix deserialization not initializing properties when they have a default value and the field is not found in the payload #1417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
joaojacome
commented
Jun 18, 2022
joaojacome
commented
| Q | A |
|---|---|
| Bug fix? | yes |
| New feature? | no |
| Doc updated | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | ... |
| License | MIT |
|
@goetas sorry for pinging you, but could you take a look at this one? |
Signed-off-by: Joao Jacome <github@joaojaco.me>
Signed-off-by: Joao Jacome <github@joaojaco.me>
…s default value when the field does not exist in the payload Signed-off-by: Joao Jacome <github@joaojaco.me>
Signed-off-by: Joao Jacome <github@joaojaco.me>
goetas
force-pushed
the
constructor-promotion
branch
from
2333e9a
to
fa3e3ca
Compare
|
thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.