Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JasPer - Fix sanity check paths for Debian OS #5897

Merged
merged 2 commits into from
Feb 25, 2018
Merged

JasPer - Fix sanity check paths for Debian OS #5897

merged 2 commits into from
Feb 25, 2018

Conversation

vanzod
Copy link
Member

@vanzod vanzod commented Feb 22, 2018

(created using eb --new-pr)

@vanzod
Copy link
Member Author

vanzod commented Feb 22, 2018

Test report by @vanzod
SUCCESS
Build succeeded for 5 out of 5 (5 easyconfigs in this PR)
cermis - Linux debian 9.3, Intel(R) Xeon(R) CPU E5620 @ 2.40GHz, Python 2.7.13
See https://gist.github.com/3c134571e3e5b47ab57aad436299e45b for a full test report.

boegel
boegel reviewed Feb 22, 2018
View reviewed changes
easybuild/easyconfigs/j/JasPer/JasPer-2.0.10-intel-2016b.eb

builddependencies = [('CMake', '3.6.1')]
builddependencies = [('CMake', '3.7.1')]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vanzod Why change the CMake here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just because I cannot build and generate a report with CMake/3.6.1 on Debian 9.
I can revert it back now that a report is there.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why? CMake 3.6.1 doesn't build on Debian 9?

I prefer stick to our policy of not bumping dependency versions, although here it's not a huge issue since it's only a build dep...

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, nevermind, if this helps on Debian 9, it's fine to bump the version in this particular case since it can't introduce any conflicts.

@boegel boegel added this to the next release (3.5.2 or 3.6.0) milestone Feb 22, 2018
@boegel boegel added the bug fix label Feb 22, 2018
@boegel
Copy link
Member

boegel commented Feb 22, 2018

Test report by @boegel
SUCCESS
Build succeeded for 5 out of 5 (5 easyconfigs in this PR)
node2428.golett.os - Linux centos linux 7.4.1708, Intel(R) Xeon(R) CPU E5-2680 v3 @ 2.50GHz, Python 2.7.5
See https://gist.github.com/f7dca2e57261c19264fa58adf470dc72 for a full test report.

@boegel boegel mentioned this pull request Feb 23, 2018
Closed
@boegel
Copy link
Member

boegel commented Feb 25, 2018

Going in, thanks @vanzod!

@boegel boegel merged commit 9cf6d10 into easybuilders:develop Feb 25, 2018
@vanzod vanzod mentioned this pull request Apr 18, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@boegel boegel boegel approved these changes

Assignees
No one assigned
Labels
bug fix
Projects
None yet
Milestone
3.5.2
Development

Successfully merging this pull request may close these issues.
2 participants
@vanzod @boegel