add support for enabling fallback in sanity check to consider lib64 equivalent for seemingly missing libraries #2477
Conversation
…ib64 equivalent for libraries
|
Very useful addition. I would even push it forward an make it two-ways, so that [1] easybuilders/easybuild-easyconfigs#4722 |
|
As a more general solution, perhaps for later, wondering if wouldn't be better to put symlinks to all libs found inside |
boegel
changed the title
easybuild/framework/easyblock.py
Outdated
|
|
||
| # for library files in lib/, also consider fallback to lib64/ equivalent | ||
| if not found and build_option('lib64_fallback_sanity_check'): | ||
| if all(x.startswith('lib/') for x in xs): |
There was a problem hiding this comment.
I don't understand this all? why do all paths have to start with lib/?
There was a problem hiding this comment.
a wait, xs is a tuple which we do OR?
There was a problem hiding this comment.
Yes, xs is one entry from e.g. the files list from sanity_check_paths can be a tuple (and if it's just a string, we make it a tuple with a single element higher up).
…hen --lib64-fallback-sanity-check is enabled
…a --disable-lib64-fallback-sanity-check
|
@vanzod Reverse (also considering In addition, I enabled the lib64 fallback in the sanity check by default; it can be disabled if desired via |
boegel
changed the title
This is an alternate implementation of the proposed change by @torbjoernk in #1405, as a fix for #1404.
I prefer keeping this optional, since having the fallback enabled by default may result in the sanity check passing where it perhaps shouldn't (although maybe I'm being too careful here, I'm not sure...).
This is fueled by the issues that @pmatousu has been reporting for failing sanity checks on SUSE systems, cfr. easybuilders/easybuild-easyblocks#1400 and easybuilders/easybuild-easyconfigs#6165 .