Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

{lib}[dummy] pyslurm v17.11.0.9 #6918

Closed

Conversation

boegel
Copy link
Member

@boegel boegel commented Sep 26, 2018

(created using eb --new-pr)

@boegel boegel added this to the 3.7.1 milestone Sep 26, 2018
@boegel boegel requested a review from vanzod September 26, 2018 20:17
@boegel
Copy link
Member Author

boegel commented Sep 26, 2018

Test report by @boegel
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in this PR)
node3145.skitty.os - Linux centos linux 7.5.1804, Intel(R) Xeon(R) Gold 6140 CPU @ 2.30GHz, Python 2.7.5
See https://gist.github.com/fc83b2196acc5bb0d6126b9e31fb957f for a full test report.

@boegel boegel changed the title {lang,lib}[dummy/,dummy/dummy] pyslurm v17.11.0.9, Cython v0.28.2 {lib}[dummy] pyslurm v17.11.0.9 Sep 26, 2018
@vanzod
Copy link
Member

vanzod commented Oct 1, 2018

Test report by @vanzod
FAILED
Build succeeded for 0 out of 2 (2 easyconfigs in this PR)
cermis - Linux debian 9.5, Intel(R) Xeon(R) CPU E5620 @ 2.40GHz, Python 2.7.13
See https://gist.github.com/32cb6f8f4ec14da5bf61605d606876cf for a full test report.

@vanzod
Copy link
Member

vanzod commented Oct 1, 2018

This is strange. I do not see why the lib/lib64 fallback introduced in easybuilders/easybuild-framework#2477 is not working here...

@boegel
Copy link
Member Author

boegel commented Oct 1, 2018

@vanzod Because there's a bug in the fallback mechanism, here's the relevant log message:

== 2018-10-01 09:47:24,634 easyblock.py:2301 INFO (non-empty) directory not found at 'lib64/python2.7/site-packages' in /opt/easybuild/software/Core/Cython/0.28.2, consider fallback locations: 'lib/site-packages'

@boegel
Copy link
Member Author

boegel commented Oct 1, 2018

@vanzod Should be fixed with easybuilders/easybuild-framework#2602...

@vanzod
Copy link
Member

vanzod commented Oct 9, 2018

I cannot test it since my test box does not have Slurm installed and the one available in the OS repo is too old for this version of pyslurm.

@boegel
Copy link
Member Author

boegel commented Oct 9, 2018

Maybe @akesandgren can test?

@pescobar
Copy link
Member

pescobar commented Oct 9, 2018

Test report by @pescobar
FAILED
Build succeeded for 1 out of 2 (2 easyconfigs in this PR)
login20.cluster.bc2.ch - Linux centos linux 7.3.1611, Intel(R) Xeon(R) CPU E5-2670 v2 @ 2.50GHz, Python 2.7.5
See https://gist.github.com/c791c67e33c4546efa4a75319e96adfb for a full test report.

@pescobar
Copy link
Member

pescobar commented Oct 9, 2018

after I triggered the test I realized that my system is running slurm 17.02.3 so my failed build is expected

@boegel boegel modified the milestones: 3.7.1, next release Oct 10, 2018
@boegel boegel modified the milestones: 3.8.0, 3.8.1 Dec 14, 2018
@boegel boegel modified the milestones: 3.8.1, 3.x Jan 19, 2019
Copy link
Contributor

@akesandgren akesandgren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@boegel
Copy link
Member Author

boegel commented Jan 19, 2019

Tried reinstalling this for the fun of it, now fails with:

INFO: Build - Detected Slurm version - 0x110b08 (17.11.08)
ERROR: Build - Incorrect slurm version detected, require Slurm-17.11.00 to slurm-17.11.07

So, garbage, and I don't have a need for this anymore, so I'll close this PR.

@boegel boegel closed this Jan 19, 2019
@boegel boegel deleted the 20180926221722_new_pr_pyslurm171109 branch January 19, 2019 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants