Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provide generic way for sanity_check to look in both lib and lib64 for library files #1404

Closed
torbjoernk opened this issue Sep 28, 2015 · 1 comment
Milestone

Comments

@torbjoernk
Copy link

AFAIK the only way of checking whether library files ended up in lib/ or lib64/ is via

sanity_check_paths = {
  'files': [
    ('lib/myLib.so', 'lib64/myLib.so'),
    ('lib/myLib.a', 'lib64/myLib.a')
  ]
}

Wouldn't it be nice having this collapsing into something like

sanity_check_paths = {
  'files': [
    LibraryPathBuilder('myLib', shared=True, static=True)
  ]
}

It's less error prone to typos and way less tedious.

torbjoernk added a commit to torbjoernk/easybuild-framework that referenced this issue Sep 28, 2015
This is a suggestion to fix easybuilders#1404.
Don't know whether it breaks something elsewhere ...

Signed-off-by: Torbjörn Klatt <t.klatt@fz-juelich.de>
torbjoernk added a commit to torbjoernk/easybuild-framework that referenced this issue Sep 28, 2015
This is a suggestion to fix easybuilders#1404.
Don't know whether it breaks something elsewhere ...

Signed-off-by: Torbjörn Klatt <t.klatt@fz-juelich.de>
@boegel boegel modified the milestone: v2.x Jan 23, 2016
@boegel boegel modified the milestones: 3.x, 3.6.1 Aug 29, 2018
@boegel
Copy link
Member

boegel commented Aug 29, 2018

EasyBuild will now (since v3.6.1) automatically consider lib64/... paths whenever a lib/... is specified (and vice versa), see #2477, thanks again for the idea @torbjoernk!

@boegel boegel closed this as completed Aug 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants