Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for temporarily disabling requirement that all template values must resolve via EasyConfig.expect_resolved_template_values #4726

Merged
merged 2 commits into from
Dec 19, 2024

Conversation

boegel
Copy link
Member

@boegel boegel commented Dec 19, 2024

…alues must resolve via EasyConfig.expect_resolved_template_values
Copy link
Contributor

@lexming lexming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lexming lexming enabled auto-merge December 19, 2024 10:29
@lexming lexming merged commit 2fd30ae into easybuilders:5.0.x Dec 19, 2024
39 checks passed
@boegel boegel deleted the expect_resolved_template_values branch December 19, 2024 12:49
@Flamefire
Copy link
Contributor

Did you consider adding a context manager similar to #3287 to avoid forgetting to re-enable it? In the linked PR it looks like it could stay disabled in a refactoring or on error affecting other tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Breaking changes
Development

Successfully merging this pull request may close these issues.

3 participants