Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing select helpers #133

Closed
4 of 7 tasks
strengejacke opened this issue Mar 21, 2022 · 4 comments · Fixed by #376
Closed
4 of 7 tasks

Missing select helpers #133

strengejacke opened this issue Mar 21, 2022 · 4 comments · Fixed by #376

Comments

@strengejacke
Copy link
Member

strengejacke commented Mar 21, 2022

See #128

Needs select helpers:

Needs to move secondary select-args (basically, data frame method should have argument order of numeric/vector, followed by select/exclude):

For some functions, select/exclude come after some main arguments, but not at the end. I'm not sure if this is a problem?

strengejacke added a commit that referenced this issue Mar 21, 2022
strengejacke added a commit that referenced this issue Mar 21, 2022
@strengejacke
Copy link
Member Author

ok, in #135 I now have tried to implement a consistent logic for argument order, also that numeric/factor/data frame methods are consistent. In general, verbose goes last. Where select/exclude are secondary, these + ignore_case come before verbose.

@strengejacke strengejacke changed the title Harmonize argument order Missing select helpers Mar 21, 2022
@strengejacke
Copy link
Member Author

I think #47 needs to be finished first before we can add select helpers here.

strengejacke added a commit that referenced this issue Apr 12, 2022
strengejacke added a commit that referenced this issue Apr 30, 2022
@IndrajeetPatil
Copy link
Member

#47 won't be worked on for a while, so I think this issue doesn't have to wait for it.

@etiennebacher
Copy link
Member

unstandardize() needs to be updated to accept NSE:

library(datawizard)

iris |> 
  standardize(select = starts_with("Sep")) |> 
  unstandardise(select = starts_with("Sep"))
#> Error in starts_with("Sep"): impossible de trouver la fonction "starts_with"

Created on 2023-03-09 with reprex v2.0.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants