Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dcp-967 managed access #151

Merged
merged 33 commits into from
Nov 9, 2023
Merged

dcp-967 managed access #151

merged 33 commits into from
Nov 9, 2023

Conversation

amnonkhen
Copy link
Contributor

@amnonkhen amnonkhen commented Sep 20, 2023 •
edited
Loading

support for managed access data ingest

summary of changes

  • managed_access.md - sequence diagrams explaining how api is protected & managed access flow
  • RowLevelSecurityAspect - an AOP style code that advices the Metadata Repository findBy* methods and filters their results according to datasets a user is allowed to see.
  • ProjectController - class where various project related metadata web resources are implemented. Relevant methods are protected to check the user's access rights to the given project.

links:

dcp-967
ebi-ait/dcp-ingest-central#967

@amnonkhen amnonkhen self-assigned this Sep 20, 2023
@amnonkhen
dcp-967 managed access - require authentication for all read operations
22ecd0b
@amnonkhen
dcp-967 managed access - design docs
53c0803
@amnonkhen
dcp-967 managed access - design docs
a4b100b
@amnonkhen
dcp-967 managed access - design docs
094be26
@amnonkhen
dcp-967 managed access - design docs
2c4fb3c
@amnonkhen
dcp-967 managed access - design docs
531d2a4
@amnonkhen
dcp-967 (de)serialisation of DataAccessTypes
53f86d6
@amnonkhen
dcp-967 managed access - require authentication for all read operations
3447fd4
@amnonkhen
dcp-967 tests for ProjectBuilder
5eacd23
@amnonkhen
dcp-967 (de)serialisation of DataAccessTypes
5ca8b6a
@amnonkhen
dcp-967 managed access - require authentication for all read operations
8389a05
@amnonkhen
dcp-967 managed access - filter metadata resources by user's allowed …
f7794ed 
…projects
@amnonkhen
dcp-967 managed access - filter metadata resources by user's allowed …
6bd1c9d 
…projects
@amnonkhen
dcp-967 managed access - filter metadata resources by user's allowed …
9383c6c 
…projects
@amnonkhen
dcp-967 managed access - filter metadata resources by user's allowed …
6c014dd 
…projects
@amnonkhen
dcp-967 managed access - filter metadata resources by user's allowed …
e5eadc0 
…projects
@amnonkhen
dcp-967 managed access - filter metadata resources by user's allowed …
beff1ac 
…projects
@amnonkhen
dcp-967 managed access - filter metadata resources by user's allowed …
b05b306 
…projects
@amnonkhen
dcp-967 managed access - filter metadata resources by user's allowed …
525a76a 
…projects
@amnonkhen
dcp-967 managed access - filter metadata resources by user's allowed …
a850bc0 
…projects
@amnonkhen
dcp-967 managed access - filter metadata resources by user's allowed …
5b692b6 
…projects
@amnonkhen
dcp-967 managed access - fix unit tests
e8117bc
@amnonkhen
dcp-967 managed access - filter metadata resources by user's allowed …
c951101 
…projects
@amnonkhen
dcp-967: managed access: dataAccess as a project schema property
d650992
@amnonkhen
dcp-967 managed access - require authentication for all read operations
9ff9849
@amnonkhen
dcp-967 managed access - fix unit tests
6273072
@amnonkhen
Copy link
Contributor Author

unit tests and integration tests of core are passing. I am going to merge this PR to dev so it is in stalled and I can run some system tests.

@amnonkhen amnonkhen marked this pull request as ready for review November 9, 2023 22:20
@amnonkhen amnonkhen merged commit d525a07 into dev Nov 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gabsie gabsie Awaiting requested review from gabsie

@tburdett tburdett Awaiting requested review from tburdett

Assignees

@amnonkhen amnonkhen

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@amnonkhen