updated rxjs version from 6 to 7, ts to 4.2.4, and some refactor #2535
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for taquito-test-dapp ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
New packages have been deployed to the preview repository at https://npm.preview.tezostaquito.io/. Published packages: |
|
A new deploy preview is available on Netlify at https://9e5b818--tezostaquito.netlify.app |
hui-an-yang
reviewed
Jun 28, 2023
hui-an-yang
reviewed
Jun 28, 2023
hui-an-yang
reviewed
Jun 28, 2023
| @@ -58,7 +59,8 @@ export class BatchOperation | |||
| .filter((result) => BATCH_KINDS.indexOf(result.kind) !== -1) | |||
| .map((result) => { | |||
| if (hasMetadataWithResult(result)) { | |||
| return result.metadata.operation_result.status; | |||
| const opResult = result.metadata.operation_result as BatchOperationResult; | |||
There was a problem hiding this comment.
is it better to defined opResult as type BatchOperationResult then to cast it?
const opResult: BatchOperationResult = result.metadata.operation_result;
There was a problem hiding this comment.
casting is necessary still since opResult is type unknown. TS will also throw an error if you only type it as such. Same comment as the other one
There was a problem hiding this comment.
the operation_result type seems lost in hasMetadataWithResult, will we consider defined it better in the function so we can avoid casting
There was a problem hiding this comment.
TS unfortunately doesn't derive the subset of types from hasMetadataWithResult. It will always return unknown regardless, which is the reason why we needed to cast it
hui-an-yang
reviewed
Jun 28, 2023
hui-an-yang
reviewed
Jun 28, 2023
| @@ -130,7 +135,7 @@ export class Operation { | |||
| return ( | |||
| this.results.map((result) => { | |||
| if (hasMetadataWithResult(result)) { | |||
| return result.metadata.operation_result.status; | |||
| return (result.metadata.operation_result as OperationResult).status; | |||
There was a problem hiding this comment.
preference wise, i'd declare type defined variable and return variable.status then casting.
There was a problem hiding this comment.
same comment as the one above
hui-an-yang
reviewed
Jun 28, 2023
hui-an-yang
reviewed
Jun 28, 2023
hui-an-yang
reviewed
Jun 28, 2023
hui-an-yang
reviewed
Jun 28, 2023
hui-an-yang
reviewed
Jun 28, 2023
There was a problem hiding this comment.
thanks for updating example!!
dvkam
pushed a commit
to dvkam/taquito
that referenced
this pull request
Jul 6, 2023
…dlabs#2535) * updated rxjs version from 6 to 7, ts to 4.2.4, and some necessary refactors * updated unit tests, and refactored necessary packages * updated example * addressed PR comments * debug tests * debug flextesa failure * remove debug statements * trigger build * try previous flextesa version
hui-an-yang
pushed a commit
that referenced
this pull request
Jul 11, 2023
* fix issues from #1652 * added TZIP link above the column caption * removed the TZIP link at the bottom of the page * updated rxjs version from 6 to 7, ts to 4.2.4, and some refactor (#2535) * updated rxjs version from 6 to 7, ts to 4.2.4, and some necessary refactors * updated unit tests, and refactored necessary packages * updated example * addressed PR comments * debug tests * debug flextesa failure * remove debug statements * trigger build * try previous flextesa version * fix issues from #1652 * changed color back to brown like it was before --------- Co-authored-by: Davis Sawali <davis.sawali@ecadlabs.com> Co-authored-by: David <david.kaminski93@gmail.com>
hui-an-yang
added a commit
that referenced
this pull request
Jul 17, 2023
* Fix issue #1652 (#2547) * fix issues from #1652 * added TZIP link above the column caption * removed the TZIP link at the bottom of the page * updated rxjs version from 6 to 7, ts to 4.2.4, and some refactor (#2535) * updated rxjs version from 6 to 7, ts to 4.2.4, and some necessary refactors * updated unit tests, and refactored necessary packages * updated example * addressed PR comments * debug tests * debug flextesa failure * remove debug statements * trigger build * try previous flextesa version * fix issues from #1652 * changed color back to brown like it was before --------- Co-authored-by: Davis Sawali <davis.sawali@ecadlabs.com> Co-authored-by: David <david.kaminski93@gmail.com> * docs: extended website adjustment changes to next version * revert: package-lock.json to comply with master * docs: removed broken link in lambda_view and update sapling contract for live code example * docs: updated version 17.1.0 doc changes accordingly --------- Co-authored-by: dvkam <82422481+dvkam@users.noreply.github.com> Co-authored-by: Davis Sawali <davis.sawali@ecadlabs.com> Co-authored-by: David <david.kaminski93@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #2261
@taquito/taquitopackage (and the parent package) from 4.1.5 to 4.2.4Thank you for your contribution to Taquito.
Before submitting this PR, please make sure:
In this PR, please also make sure:
closes #TICKETNUMBERin the description box (when applicable)Release Note Draft Snippet
If relevant, please write a summary of your change that will be suitable for
inclusion in the Release Notes for the next Taquito release.