Fix issue #1652 #2547
Fix issue #1652 #2547
Conversation
✅ Deploy Preview for taquito-test-dapp ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Hello @dvkam, your contribution is much appreciated! The code looks good, but it seems that there's a merge conflict. Do you mind rebasing with current master? |
…dlabs#2535) * updated rxjs version from 6 to 7, ts to 4.2.4, and some necessary refactors * updated unit tests, and refactored necessary packages * updated example * addressed PR comments * debug tests * debug flextesa failure * remove debug statements * trigger build * try previous flextesa version
|
Hey @dsawali should be done. Let me know if there is anything else! |
|
Thank you @dvkam, the files changed seem to have a lot of the things that already exist in master but highlighted as 'changed'. Kinda weird 🤔 |
|
Hi @dvkam, We really appreciate your contribution to make our website better 🙌. |
dvkam
changed the base branch from
master
to
support-dvkam-contribution-of-website-adjustments
|
Hello @hui-an-yang thank you for your help. I just pointed the pr to branch Not sure what happened, I suppose I did something wrong during rebase with master. Now looking at changed files it looks good (to me). |
hui-an-yang
merged commit 00b80e4
into
ecadlabs:support-dvkam-contribution-of-website-adjustments
* Fix issue #1652 (#2547) * fix issues from #1652 * added TZIP link above the column caption * removed the TZIP link at the bottom of the page * updated rxjs version from 6 to 7, ts to 4.2.4, and some refactor (#2535) * updated rxjs version from 6 to 7, ts to 4.2.4, and some necessary refactors * updated unit tests, and refactored necessary packages * updated example * addressed PR comments * debug tests * debug flextesa failure * remove debug statements * trigger build * try previous flextesa version * fix issues from #1652 * changed color back to brown like it was before --------- Co-authored-by: Davis Sawali <davis.sawali@ecadlabs.com> Co-authored-by: David <david.kaminski93@gmail.com> * docs: extended website adjustment changes to next version * revert: package-lock.json to comply with master * docs: removed broken link in lambda_view and update sapling contract for live code example * docs: updated version 17.1.0 doc changes accordingly --------- Co-authored-by: dvkam <82422481+dvkam@users.noreply.github.com> Co-authored-by: Davis Sawali <davis.sawali@ecadlabs.com> Co-authored-by: David <david.kaminski93@gmail.com>
Release Note Draft Snippet
This closes issue #1652.
✅ - Adjusted the source icons to have a transparent background, so it looks well in both light and dark modes.
✅ - TZIP-10 column caption can be the same as the other ones: I removed the link in the column caption and put it above the table in the sentence Wallets that support the TZIP-10...
This way no changes in the CSS styles were needed.
✅ - Can the font for the tables be increased? It looks very tiny in comparison to the rest of the text. NOTE: This applies to the style of all the tables on the website. Hopefully, this just needs to be changed in 1 place.
Thi was just a change in one place in
tables.scss(font-size: 16px;). I increased it from12pxto16px. But if any other size is preferred please let me know.Screenshot dark mode:
Light mode:
Thank you for your contribution to Taquito.
Before submitting this PR, please make sure:
In this PR, please also make sure:
closes #TICKETNUMBERin the description box (when applicable)