Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update license_header_template. #2097

Merged
merged 1 commit into from
Jan 4, 2023

Conversation

boaks
Copy link
Contributor

@boaks boaks commented Dec 19, 2022

Add SPDX-License-Identifier: (EPL-2.0 AND BSD-3-Clause)

Signed-off-by: Achim Kraus achim.kraus@cloudcoap.net

@waynebeaton
Copy link

Think of the SPDX expression from the consumer/adopter's perspective.

I believe in this case that the idea is that one can consume Eclipse Californium content under either the EPL-2.0 OR the EPL-1.0 (which is an instance of the BSD-3-Clause).

So the expression should be EPL-2.0 OR BSD-3-Clause. The parentheses are not required (they're not wrong).

FYI, the "Documentation" link on the PMI provides some example copyright headers.

@boaks boaks force-pushed the new_license_header branch 2 times, most recently from bbbb478 to cd0eeed Compare December 20, 2022 08:11
@boaks
Copy link
Contributor Author

boaks commented Dec 20, 2022

After reading the provided link, this requires to collect the current "copyrights" into the Notice file.
so, I guess, we better keep the old style and just add the SPDX line.

@boaks boaks force-pushed the new_license_header branch from cd0eeed to 7269646 Compare December 20, 2022 08:20
@waynebeaton
Copy link

After reading the provided link, this requires to collect the current "copyrights" into the Notice file.

How so? The first option more-or-less exactly matches what you're proposing.

Only the second option--which is consistently presented as as alternative--requires tracking of specific copyright holders via a NOTICE file. FWIW, NOTICE file is intended in the abstract to mean some indication of notices; AFAIAC, the commit record service serves this purpose.

You may have noticed that none of our examples include the text "All rights reserved". This term is meaningless. My recommendation is that you remove it from your template. It's not necessarily wrong for it to be there, but it doesn't actually add anything.

@boaks
Copy link
Contributor Author

boaks commented Dec 20, 2022

AFAIAC, the commit record service serves this purpose.

OK, that sounds like adding a "refer to git reflog" in Californium's NOTICE.md will do it.
I will revise the PR.

Add SPDX-License-Identifier: EPL-2.0 OR BSD-3-Clause

Signed-off-by: Achim Kraus <achim.kraus@cloudcoap.net>
@boaks boaks force-pushed the new_license_header branch from 7269646 to 9137e6e Compare December 20, 2022 14:35
@boaks boaks mentioned this pull request Dec 27, 2022
@boaks boaks merged commit 55ba71b into eclipse-californium:main Jan 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants