Datagram drop callback #2100
Datagram drop callback #2100
Conversation
| @@ -1969,7 +2004,7 @@ public void run() { | |||
| * @since 3.5 | |||
| */ | |||
| @NoPublicAPI | |||
| protected boolean executeInbound(Executor executor, InetSocketAddress peer, LimitedRunnable job) { | |||
| protected boolean executeInbound(Executor executor, InetSocketAddress peer, LimitedRunnable job, Runnable onError) { | |||
There was a problem hiding this comment.
Maybe, extending LimitedRunnablewith an onError(RejectedExecutionException ex) callback is an alternative to a second Runnable.
Or pass in the Record instead of the second Runnable
| @@ -0,0 +1,40 @@ | |||
| /******************************************************************************* | |||
| * Copyright (c) 2022 Bosch.IO GmbH and others. | |||
There was a problem hiding this comment.
Are you an employee of Bosch.IO?
If not, please edit this according license_header_template.txt. if this is your own work not belonging to an employer, then just use your name.
There is also a pending PR #2097 . If you like, you may chose also that. I plan to replace all header when start to work in the 4.0.
|
Thanks a lot! I would like to spend some time in testing it. |
|
I see two more candidates, |
| /** | ||
| * Handles {@code RejectedExecutionException} | ||
| * @param ex the thrown exception | ||
| */ |
There was a problem hiding this comment.
Some polishing, please add
@since 3.8
|
|
||
| /** | ||
| * Extension of DatagramFilter | ||
| */ |
There was a problem hiding this comment.
Some polishing, please add a "." at the end of the first sentence and a
@since 3.8
|
Thank you for noticing |
|
LGTM |
|
I missed to ask for squashing. |
Discussion ref: #2099
I'd like to introduce injectable action on datagram/record drop with access to dropped object. As discussed in the issue two methods were prepared to be added to
DatagramFilter.