-
Notifications
You must be signed in to change notification settings - Fork 368
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Datagram drop callback #2100
Merged
boaks
merged 7 commits into
eclipse-californium:main
from
Wisien999:datagram-drop-callback
Dec 30, 2022
Merged
Datagram drop callback #2100
Changes from 5 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
48fcef5
Create callback with detailed datagram data during drop
b9aac28
remove garbage
130e0c6
fix copyright template
8e40a14
Extend LimitedRunable instead of passing Runnable to executeInBounds
2dd8e81
default implementation of onError in LimetedRunnable
6dfeffd
add missing datagramFilter.onDrop calls
82f2876
DatagramFilterExtended and LimitedRunnable#onError javadoc cosmetic c…
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
39 changes: 39 additions & 0 deletions
39
scandium-core/src/main/java/org/eclipse/californium/scandium/DatagramFilterExtended.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,39 @@ | ||
/******************************************************************************* | ||
* Copyright (c) 2022 AVSystem and others. | ||
* | ||
* All rights reserved. This program and the accompanying materials | ||
* are made available under the terms of the Eclipse Public License v2.0 | ||
* and Eclipse Distribution License v1.0 which accompany this distribution. | ||
* | ||
* The Eclipse Public License is available at | ||
* http://www.eclipse.org/legal/epl-v20.html | ||
* and the Eclipse Distribution License is available at | ||
* http://www.eclipse.org/org/documents/edl-v10.html. | ||
* | ||
* Contributors: | ||
* Bartłomiej Wiśniewski (AVSystem) - initial creation | ||
******************************************************************************/ | ||
package org.eclipse.californium.scandium; | ||
|
||
import org.eclipse.californium.elements.util.PublicAPIExtension; | ||
import org.eclipse.californium.scandium.dtls.Record; | ||
|
||
import java.net.DatagramPacket; | ||
|
||
/** | ||
* Extension of DatagramFilter | ||
*/ | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Some polishing, please add a "." at the end of the first sentence and a
|
||
@PublicAPIExtension(type = DatagramFilter.class) | ||
public interface DatagramFilterExtended { | ||
|
||
/** | ||
* Called when a datagram packed is dropped. Allows to inject packet based action in form of callback | ||
* @param packet the dropped datagram packet | ||
*/ | ||
void onDrop(DatagramPacket packet); | ||
/** | ||
* Called when a record is dropped. Allows to inject record based action in form of callback | ||
* @param record the dropped record | ||
*/ | ||
void onDrop(Record record); | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some polishing, please add