Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Tooltip #170

Closed

Conversation

maria-ericsson
Copy link

@maria-ericsson maria-ericsson commented Oct 23, 2020

Signed-off-by: maria-ericsson maria.chowdhury@ericsson.com

@mirsky-work
Copy link
Contributor

tooltips

Nice, but there are some issues that are demonstrated in the attached Gif taken from Gitpod:

  • The tooltip seems to open up at a fixed position relative to the state, and not where the cursor is.
  • It doesn't disappear when the cursor is moved. It does disappear when moving away from the chart.

Not an issue, but rather a question - what would it take to make the tooltip text "copyable", as it's already "selectable"?

@maria-ericsson
Copy link
Author

maria-ericsson commented Oct 28, 2020

tooltips

Nice, but there are some issues that are demonstrated in the attached Gif taken from Gitpod:

  • Thank you.
  • The tooltip seems to open up at a fixed position relative to the state, and not where the cursor is.
  • Tooltip position is fixed for a specific state element.
  • Tooltip position changes when a different state element is selected.
  • It doesn't disappear when the cursor is moved. It does disappear when moving away from the chart.

Not an issue, but rather a question - what would it take to make the tooltip text "copyable", as it's already "selectable"?

Tooltip disappears

  • When the mouse leaves the chart

  • Between selection of two state elements. There are two reasons for that

  1. If tooltip contains html links, then the user should be able to click link to open the relevant web-page
  2. Tooltip content should be copyable

@maria-ericsson
Copy link
Author

maria-ericsson commented Nov 6, 2020

Functionality for tooltip to follow the the click events is added.

tooltips
Nice, but there are some issues that are demonstrated in the attached Gif taken from Gitpod:

  • Thank you.
  • The tooltip seems to open up at a fixed position relative to the state, and not where the cursor is.
  • Tooltip position is fixed for a specific state element.
  • Tooltip position changes when a different state element is selected.
  • It doesn't disappear when the cursor is moved. It does disappear when moving away from the chart.

Not an issue, but rather a question - what would it take to make the tooltip text "copyable", as it's already "selectable"?

Tooltip disappears

  • When the mouse leaves the chart
  • Between selection of two state elements. There are two reasons for that
  1. If tooltip contains html links, then the user should be able to click link to open the relevant web-page
  2. Tooltip content should be copyable

--- tooltip close operation is added with a timer.
---The tooltip content is copy-able and any URL that may be present in the tooltip is clickable.
--- tooltip closes when the mouse leaves the timeline chart
--- tooltip closes when the mouse leaves the selected element.

Signed-off-by: maria-ericsson <maria.chowdhury@ericsson.com>
@bhufmann
Copy link
Collaborator

Thanks. Feature implemented by #283.

@bhufmann bhufmann closed this Mar 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants