Add tooltip support for timegraph states #283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MatthewKhouzam
approved these changes
Mar 17, 2021
There was a problem hiding this comment.
I am approving despite a bug I consider bad, I am not requesting the change because even with this bug, the tooltips are so much better than before. I know you're aware of the bug as you showed it to me. :) (hint, look at where the tooltip points)
tooltip.mp4
|
I am looking at the code, see here. tooltip-error.mp4This is pretty bad, I didn't notice before that the entry row changes too. |
Signed-off-by: Patrick Tasse <patrick.tasse@ericsson.com>
|
I think the Y axis is a little better. |
Signed-off-by: Patrick Tasse <patrick.tasse@ericsson.com>
|
HARD +2 |
bhufmann
approved these changes
Mar 19, 2021
This was referenced Mar 22, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Patrick Tasse patrick.tasse@ericsson.com