Avoid creating multiple clients per project #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a file is opened within a project while a client for that project already exists, we create a new client to replace the old one in the map, without disposing of the old client. Fixes: 1. If createClient replaces a client in the map, always dispose of the replaced client to avoid leaking clients. 2. Remove now redundant calls to disposeClient which are made just before calls to createClient for the same project. 3. Don't call createClient at all when a document is opened in a project if a client already exists for the given project.
|
@bddavis Thanks for opening this PR. There was an issue with my watch notifications so I did not receive a trigger for this PR. |
|
Since cdt.cloud is a member of the Eclipse Foundation, all contributors must first sign the Eclipse Contributor Agreement (ECA) before their code changes can be merged into source. The Eclipse Foundation maintains an ECA FAQ with more information about the ECA’s provisions. To do so you need to have an account on [eclipse.org](Eclipse projects forge) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a file is opened within a project while a client for that project already exists, we create a new client to replace the old one in the map, without disposing of the old client.
Fixes: