Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid creating multiple clients per project #9

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Avoid creating multiple clients per project #9

wants to merge 1 commit into from

Commits on Sep 28, 2024

  1. Avoid creating multiple clients per project 

    If a file is opened within a project while a client for that
project already exists, we create a new client to replace
the old one in the map, without disposing of the old client.

Fixes:
1. If createClient replaces a client in the map, always dispose
of the replaced client to avoid leaking clients.
2. Remove now redundant calls to disposeClient which are made
just before calls to createClient for the same project.
3. Don't call createClient at all when a document is opened
in a project if a client already exists for the given project.
    @bddavis
    bddavis committed Sep 28, 2024
    Configuration menu
    Copy the full SHA
    85a6446 View commit details
    Browse the repository at this point in the history