Provide viewer filter for absent C/C++ translation unit files #597
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jld01
commented
Oct 16, 2023
| @@ -4203,6 +4203,12 @@ | |||
| description="%HideNonCElements.description" | |||
| id="org.eclipse.cdt.ui.navigator.filters.NonCElementFilter" | |||
| name="%HideNonCElements.label"/> | |||
| <commonFilter | |||
| activeByDefault="true" | |||
There was a problem hiding this comment.
@jonahgraham how shall we proceed on a final decision regarding default activation state of this filter?
There was a problem hiding this comment.
If no one objects, I think active by default as the change makes it visible and it is easy enough to restore old behavior. It is hard for users to discover new features, and if we don't activate by default most people won't find it.
If someone objects, then we can have a formal vote on cdt-dev.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #563