-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ability to show a warning banner by configuring CheCluster CR (#466) #478
Conversation
Skipping CI for Draft Pull Request. |
* upgrade devfile-converter Signed-off-by: Oleksii Orel <oorel@redhat.com> * feat: upgrade vulnerable libraries Signed-off-by: Oleksii Orel <oorel@redhat.com> * feat: fix local start flow Signed-off-by: Oleksii Orel <oorel@redhat.com> * fix: remove Keycloak's part from README Signed-off-by: Oleksii Orel <oorel@redhat.com>
Signed-off-by: Oleksii Orel <oorel@redhat.com>
* feat: using SERVICE ACCOUNT token for access to Custom Resources Signed-off-by: Oleksii Orel <oorel@redhat.com>
Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-478 |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: akurinnoy, ibuziuk, olexii4 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-478 |
@olexii4 thanks for the review, just wondering about the removal of the |
New changes are detected. LGTM label has been removed. |
Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-478 |
Yikes, that's a lot of changes. Some seem unrelated... like removing stuff about keycloak? |
Where is the displayed message & link configured? I scrolled the whole PR but got lost in a typescript haze, didn't see any mention of a blog post or whatnot. |
the message will be configured on the codeready-worskapces-operator defaults for |
We can add / change annotations in https://github.com/redhat-developer/devspaces-images/blob/devspaces-3-rhel-8/codeready-workspaces-operator/build/scripts/sync-che-operator-to-crw-operator.sh#L249-L258 when transforming upstream Che Operator into Dev Spaces Operator Once you have a sample bit o' text to inject there, please throw me a PR for the above repo and we can verify it's appearing in DS 3 (but not in Che 7.44) |
@nickboldt the PR for the operator has been merged - eclipse-che/che-operator#1339 |
Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-478 |
Backporting eclipse-che/che#20724 to 7.42.x
PR contains a number of commits to make the warning header functionality work as expected. Verified against the
che-dev
dogfooding instance: