-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow creating multiple workspaces from the single sample #622
Conversation
Skipping CI for Draft Pull Request. |
Codecov Report
@@ Coverage Diff @@
## main #622 +/- ##
==========================================
+ Coverage 58.33% 59.02% +0.69%
==========================================
Files 247 247
Lines 8071 8262 +191
Branches 1326 1348 +22
==========================================
+ Hits 4708 4877 +169
- Misses 3172 3194 +22
Partials 191 191
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-622 |
Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-622 |
/retest |
...s/dashboard-frontend/src/containers/Loader/Factory/Steps/Apply/Resources/prepareResources.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested it with https://eclipse-che.apps.cluster-8rnq4.8rnq4.sandbox506.opentlc.com. All works as expected.
Good job.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, +1 to promote to the dogfooding
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: akurinnoy, ibuziuk, olexii4 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
New changes are detected. LGTM label has been removed. |
Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-622 |
- Changed `AlertItem` to contain list of an action callbacks - Added a new step to the Workspace loading flow to handle limit of running workspaces - Updated loaders steps so they provide alert items with action callbacks
containers/Loader/Factory/Steps/ApplyDevfile -> containers/Loader/Factory/Steps/Apply/Devfile containers/Loader/Factory/Steps/ApplyResources -> containers/Loader/Factory/Steps/Apply/Resources containers/Loader/Factory/Steps/FetchDevfile -> containers/Loader/Factory/Steps/Fetch/Devfile containers/Loader/Factory/Steps/FetchResources -> containers/Loader/Factory/Steps/Fetch/Resources
to handle creating workspaces from either a devfile or pre-built resources
when switching in same tab between workspaces or to the workspaces list
f64cfbe
to
e23f77c
Compare
Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-622 |
@akurinnoy: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
What does this PR do?
This PR main goal is to allow users to create multiple workspaces from the same sample. To get this I added a new step to the Factory flow that handles workspace names conflict and prompts the user whether to switch to an existing workspace or to proceed to create a new workspace (appending a suffix to its name):
Opening the existing workspace:
Screen.Recording.2022-09-12.at.11.32.37.mov
Creating a new workspace:
Screen.Recording.2022-09-12.at.11.34.14.mov
Additionally, this PR changes a bit the workspace loading flow: it adds a new step to check if the number of simultaneously running workspaces is within the limit:
Screen.Recording.2022-09-12.at.11.36.05.mov
What issues does this PR fix or reference?
fixes eclipse-che/che#21561
Is it tested? How?
You can test this PR here: https://eclipse-che.apps.cluster-8rnq4.8rnq4.sandbox506.opentlc.com/, or use your Eclipse Che installation with this Dashboard image quay.io/eclipse/che-dashboard:pr-622.