Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore default components when a devfile references a parent #773

Merged
merged 1 commit into from
Apr 11, 2023

Conversation

olexii4
Copy link
Contributor

@olexii4 olexii4 commented Apr 10, 2023

What does this PR do?

Ignore default components when a devfile references a parent.

What issues does this PR fix or reference?

fixes eclipse-che/che#22103

Signed-off-by: Oleksii Orel <oorel@redhat.com>
@olexii4 olexii4 requested a review from ibuziuk April 10, 2023 13:12
@olexii4 olexii4 requested a review from akurinnoy as a code owner April 10, 2023 13:12
@che-bot
Copy link
Contributor

che-bot commented Apr 10, 2023

Click here to review and test in web IDE: Contribute

@codecov
Copy link

codecov bot commented Apr 10, 2023

Codecov Report

Merging #773 (f68ae41) into main (5475ca2) will increase coverage by 0.00%.
The diff coverage is 69.23%.

@@           Coverage Diff           @@
##             main     #773   +/-   ##
=======================================
  Coverage   77.82%   77.82%           
=======================================
  Files         319      319           
  Lines       31571    31573    +2     
  Branches     1906     1907    +1     
=======================================
+ Hits        24570    24572    +2     
  Misses       6947     6947           
  Partials       54       54           
Flag Coverage Δ
unittests 77.82% <69.23%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...nd/src/store/FactoryResolver/normalizeDevfileV2.ts 71.20% <69.23%> (+0.46%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@github-actions
Copy link

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-773

@openshift-ci
Copy link

openshift-ci bot commented Apr 11, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: akurinnoy, ibuziuk, olexii4

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@olexii4 olexii4 merged commit dc11e54 into main Apr 11, 2023
@olexii4 olexii4 deleted the CHE-22103 branch April 11, 2023 13:46
@devstudio-release
Copy link

Build 3.7 :: dashboard_3.x/236: Console, Changes, Git Data

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

Build 3.7 :: dashboard_3.x/236: SUCCESS

Upstream sync done; /DS_CI/sync-to-downstream_3.x/3000 triggered

@devstudio-release
Copy link

Build 3.7 :: update-digests_3.x/2767: Console, Changes, Git Data

@devstudio-release
Copy link

Build 3.7 :: update-digests_3.x/2767: UNSTABLE

No new images detected: nothing to do!

@devstudio-release
Copy link

Build 3.7 :: dashboard_3.x/237: Console, Changes, Git Data

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

Build 3.7 :: dashboard_3.x/237: SUCCESS

Upstream sync done; /DS_CI/sync-to-downstream_3.x/3048 triggered

@devstudio-release
Copy link

Build 3.7 :: update-digests_3.x/2824: Console, Changes, Git Data

@devstudio-release
Copy link

Build 3.7 :: update-digests_3.x/2824: UNSTABLE

No new images detected: nothing to do!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When a devfile references a parent we should not add the default component
5 participants