Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When a devfile references a parent we should not add the default component #22103

Closed
l0rd opened this issue Mar 27, 2023 · 6 comments · Fixed by eclipse-che/che-dashboard#773 or eclipse-che/che-dashboard#779
Assignees
Labels
area/dashboard kind/bug Outline of a bug - must adhere to the bug report template. severity/P1 Has a major impact to usage or development of the system. sprint/current
Milestone

Comments

@l0rd
Copy link
Contributor

l0rd commented Mar 27, 2023

Is your enhancement related to a problem? Please describe

When a devfile has parent (full sample):

schemaVersion: 2.2.0
metadata:
  name: inventory-quarkus
parent:
  id: java-maven
  registryUrl: https://registry.devfile.io/
  version: 1.2.0

the resulting Pod has 3 containers (the gateway, the one defined in the parent and the default one):

$ kubectl get pods <pod-name> -o json | jq -r '.spec.containers[].image'
registry.access.redhat.com/ubi8/openjdk-11:latest
quay.io/devfile/universal-developer-image:ubi8-38da5c2
quay.io/eclipse/che--traefik:v2.9.6-bb7be8d50edf73d8d3a812ac8873ef354a0fe9b40d7f3880747b43a3525855d2

Describe the solution you'd like

The default component (the universal-developer-image in the case above) should not be added if there is a parent.

@l0rd l0rd added kind/bug Outline of a bug - must adhere to the bug report template. area/dashboard severity/P1 Has a major impact to usage or development of the system. labels Mar 27, 2023
@l0rd l0rd changed the title When the devfile has a parent we should not add the default component When a devfile references a parent we should not add the default component Mar 27, 2023
@azatsarynnyy

This comment was marked as off-topic.

@ibuziuk
Copy link
Member

ibuziuk commented Mar 29, 2023

would be nice to backport it to Dev Spaces 3.5

@l0rd
Copy link
Contributor Author

l0rd commented Apr 18, 2023

Now I cannot even start a workspace

image

@ibuziuk ibuziuk reopened this Apr 18, 2023
@ibuziuk
Copy link
Member

ibuziuk commented Apr 18, 2023

@ibuziuk
Copy link
Member

ibuziuk commented Apr 18, 2023

We investigated the issue with @olexii4 and it looks like the problem is on the devworkspace generator end cc: @svor

Basically, when devfile contains the parent reference we should not fail with the error.
N.B It is important to backport the fix to 7.64.x for Dev Spaces 3.6 cc: @nickboldt

@ibuziuk
Copy link
Member

ibuziuk commented Apr 19, 2023

@l0rd should be fixed and also backported to 7.64.x for 3.6
verifed on dogfooding against che-incubator/quarkus-api-example#40

@ibuziuk ibuziuk moved this from 🚧 In Progress to ✅ Done in Eclipse Che Team A Backlog Apr 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/dashboard kind/bug Outline of a bug - must adhere to the bug report template. severity/P1 Has a major impact to usage or development of the system. sprint/current
Projects
None yet
4 participants