Skip to content
This repository has been archived by the owner on Aug 16, 2024. It is now read-only.

Ignore default components check when a devfile references a parent #738

Merged
merged 2 commits into from
Apr 18, 2023

Conversation

olexii4
Copy link
Contributor

@olexii4 olexii4 commented Apr 18, 2023

What does this PR do?

Ignore default components check when a devfile references a parent.

Screenshot/screencast of this PR

It needs for eclipse-che/che#22103

What issues does this PR fix or reference?

How to test this PR?

  1. Create a new workspace from https://gist.githubusercontent.com/olexii4/fc3b757806e660dee0fbe1bc131df3d1/raw/1212b86a69440a30d3d06cbe412c72bbbb665daf/empty.yaml
schemaVersion: 2.2.0
metadata:
  generateName: empty
parent:
  id: udi
  registryUrl: https://registry.stage.devfile.io/
  version: 1.0.0

Знімок екрана 2023-04-18 о 16 15 30

PR Checklist

As the author of this Pull Request I made sure that:

Reviewers

Reviewers, please comment how you tested the PR when approving it.

Signed-off-by: Oleksii Orel <oorel@redhat.com>
@github-actions
Copy link

Click here to review and test in web IDE: Contribute

Copy link
Contributor

@svor svor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -28,6 +28,9 @@ export class DevContainerComponentFinder {

// only one, fine, else error
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we probably should update or remove the comment above ^

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have fixed it

Copy link
Member

@ibuziuk ibuziuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@olexii4 👍
could you please make sure that we backport the fix to 7.64.x for Dev Spaces 3.6

@olexii4 olexii4 merged commit 1f238bb into main Apr 18, 2023
@olexii4 olexii4 deleted the CHE-22103 branch April 18, 2023 13:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants