This repository has been archived by the owner on Aug 16, 2024. It is now read-only.
Update offline registry endpoint env var to not mention https #129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Angel Misevski <amisevsk@redhat.com>
amisevsk
requested review from
l0rd,
nickboldt,
rhopp,
skabashnyuk and
vparfonov
as code owners
|
cc: @tomgeorge |
|
On the operator side I changed the env var to |
|
Ah, those problems with env var naming... |
ibuziuk
approved these changes
Oct 24, 2019
There was a problem hiding this comment.
LGTM, as long as env naming would be consistent with eclipse-che/che-operator#102
Signed-off-by: Angel Misevski <amisevsk@redhat.com>
|
thanks! 🙇♂️ |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Change environment variable for offline public endpoint to
CHE_DEVFILE_HTTP_ENDPOINTinstead of HTTPS since it is confusing.