-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set CHE_DEVFILE_REGISTRY_URL to allow airgap operation #102
Conversation
Signed-off-by: Tom George <tg82490@gmail.com>
Can this variable contain http link? |
yes, it just needs to be whatever the external URL of the devfile registry you are going to use for airgap mode |
this https part in name confuses a bit. What if we change it to CHE_DEVFILE_REGISTRY_URL? |
Signed-off-by: Tom George <tg82490@gmail.com>
env var name has been changed to CHE_DEVFILE_REGISTRY_URL |
@skabashnyuk @tomgeorge isn't this env variable name already used by the devfile registry ? Did you really plan to change the devfile registry to adapt to the a new name ? |
IMO, it is a good idea to get rid of |
Devfile registry PR eclipse-che/che-devfile-registry#129 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@tomgeorge I believe we can remove WIP and ask for @davidfestal @skabashnyuk review |
…e not using an external devfile registry Signed-off-by: Tom George <tg82490@gmail.com>
@davidfestal @skabashnyuk removed the WIP tag. When you get a chance can you please review? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Will this be included in 7.3.1? It's on the list so hoping it can be merged before 7.3.1 release starts on Monday.
LGTM |
This PR adds the
CHE_DEVFILE_HTTPS_ENDPOINT
variable when configuring the registries in airgap mode. It uses the public-facing route of the devfile registry, and places it in thedevfile-registry
config map, and redeploys a new version of the registry based on changes to the route.Enables eclipse-che/che#14880