Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set CHE_DEVFILE_REGISTRY_URL to allow airgap operation #102

Merged
merged 3 commits into from
Oct 28, 2019
Merged

Set CHE_DEVFILE_REGISTRY_URL to allow airgap operation #102

merged 3 commits into from
Oct 28, 2019

Conversation

tomgeorge
Copy link
Contributor

@tomgeorge tomgeorge commented Oct 23, 2019

This PR adds the CHE_DEVFILE_HTTPS_ENDPOINT variable when configuring the registries in airgap mode. It uses the public-facing route of the devfile registry, and places it in the devfile-registry config map, and redeploys a new version of the registry based on changes to the route.

Enables eclipse-che/che#14880

Signed-off-by: Tom George <tg82490@gmail.com>
@skabashnyuk
Copy link
Contributor

Can this variable contain http link?
CC @sleshchenko

@tomgeorge
Copy link
Contributor Author

yes, it just needs to be whatever the external URL of the devfile registry you are going to use for airgap mode

@skabashnyuk
Copy link
Contributor

this https part in name confuses a bit. What if we change it to CHE_DEVFILE_REGISTRY_URL?

Signed-off-by: Tom George <tg82490@gmail.com>
@tomgeorge
Copy link
Contributor Author

env var name has been changed to CHE_DEVFILE_REGISTRY_URL

@davidfestal
Copy link
Contributor

@skabashnyuk @tomgeorge isn't this env variable name already used by the devfile registry ? Did you really plan to change the devfile registry to adapt to the a new name ?

@ibuziuk
Copy link
Member

ibuziuk commented Oct 24, 2019

IMO, it is a good idea to get rid of HTTPS env var part even if the changes for devfile registry are required

@amisevsk
Copy link
Contributor

Devfile registry PR eclipse-che/che-devfile-registry#129

Copy link
Member

@ibuziuk ibuziuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ibuziuk
Copy link
Member

ibuziuk commented Oct 25, 2019

@tomgeorge I believe we can remove WIP and ask for @davidfestal @skabashnyuk review

@tomgeorge tomgeorge changed the title [WIP] Set CHE_DEVFILE_HTTPS_ENDPOINT to allow airgap operation Set CHE_DEVFILE_REGISTRY_URL to allow airgap operation Oct 25, 2019
@tomgeorge tomgeorge changed the title Set CHE_DEVFILE_REGISTRY_URL to allow airgap operation [WIP] Set CHE_DEVFILE_REGISTRY_URL to allow airgap operation Oct 25, 2019
…e not using an external devfile registry

Signed-off-by: Tom George <tg82490@gmail.com>
@tomgeorge tomgeorge changed the title [WIP] Set CHE_DEVFILE_REGISTRY_URL to allow airgap operation Set CHE_DEVFILE_REGISTRY_URL to allow airgap operation Oct 25, 2019
@tomgeorge
Copy link
Contributor Author

@davidfestal @skabashnyuk removed the WIP tag. When you get a chance can you please review?

Copy link
Contributor

@nickboldt nickboldt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Will this be included in 7.3.1? It's on the list so hoping it can be merged before 7.3.1 release starts on Monday.

@davidfestal
Copy link
Contributor

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants