Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provision GitHub OAuth using secret #1773

Merged
merged 14 commits into from
Jan 13, 2021
Merged

Provision GitHub OAuth using secret #1773

merged 14 commits into from
Jan 13, 2021

Conversation

tolusha
Copy link
Contributor

@tolusha tolusha commented Jan 4, 2021 •
edited
Loading

Read our Contribution guide before submitting a PR.

What does this PR do?

Describe how to provision GitHub OAuth with secrets

What issues does this PR fix or reference?

eclipse-che/che#18238

PR Checklist

As the author of this Pull Request I made sure that:

  • vale has been run successfully against the PR branch
  • Link checker has been run successfully against the PR branch
  • Documentation describes a scenario that is already covered by QE tests, otherwise an issue has been created and acknowledged by Che QE team
  • Changed article references are updated where they are used (or a redirect has been set up on the docs side):

screenshot-0 0 0 0_4000-2021 01 04-11_49_33

@tolusha tolusha mentioned this pull request Jan 4, 2021
Closed
79 tasks
@tolusha tolusha marked this pull request as ready for review January 4, 2021 11:47
@tolusha tolusha requested review from rkratky, themr0c and a team as code owners January 4, 2021 11:47
@tolusha tolusha requested review from l0rd and removed request for a team January 4, 2021 11:47
@tolusha
Copy link
Contributor Author

tolusha commented Jan 5, 2021

@boczkowska
Could you help me to fix linkchecker issue ?

@themr0c
Copy link
Contributor

themr0c commented Jan 5, 2021

@tolusha I fixed some linkchecker issues yesterday, maybe a rebase will help?

@yhontyk
Copy link

yhontyk commented Jan 5, 2021 •
edited
Loading

@tolusha @themr0c after the re-run of the job, no more failures :D the websites it tried to reach seemed to be unavailable at the time

PR LGTM

@yhontyk yhontyk self-assigned this Jan 5, 2021
@tolusha
Copy link
Contributor Author

tolusha commented Jan 6, 2021

Can we merge this ?

@l0rd
Copy link
Contributor

l0rd commented Jan 6, 2021

Can we merge this ?

Let me review it first

l0rd
l0rd requested changes Jan 6, 2021
View reviewed changes
Copy link
Contributor

@l0rd l0rd left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comments not really related to this PR but that need to be fixed (in this or in another PR):

  • this procedure should not be in the end-user guide, it should be in the admin guide.
  • "OAuth for GitHub allows for automatic SSH key upload to GitHub.". That's just part of it. The main reason is to support VS Code extensions that require GitHub authentication (like the GitHub Pull Request).

modules/end-user-guide/partials/proc_configuring-github-oauth.adoc Outdated Show resolved Hide resolved
modules/end-user-guide/partials/proc_configuring-github-oauth.adoc Outdated Show resolved Hide resolved
modules/end-user-guide/partials/proc_configuring-github-oauth.adoc Outdated Show resolved Hide resolved
modules/end-user-guide/partials/proc_configuring-github-oauth.adoc Outdated Show resolved Hide resolved
modules/end-user-guide/partials/proc_configuring-github-oauth.adoc Outdated Show resolved Hide resolved
modules/end-user-guide/partials/proc_configuring-github-oauth.adoc Outdated Show resolved Hide resolved
modules/end-user-guide/partials/proc_configuring-github-oauth.adoc Outdated Show resolved Hide resolved
modules/end-user-guide/partials/proc_configuring-github-oauth.adoc Outdated Show resolved Hide resolved
modules/end-user-guide/partials/proc_configuring-github-oauth.adoc Outdated Show resolved Hide resolved
@tolusha
Copy link
Contributor Author

tolusha commented Jan 8, 2021

@themr0c
Could you find a better place in admin guide to move the doc to ?

@tolusha
Copy link
Contributor Author

tolusha commented Jan 11, 2021

@l0rd
Moved to admin guide

l0rd
l0rd approved these changes Jan 13, 2021
View reviewed changes
Copy link
Contributor

@l0rd l0rd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you @tolusha

tolusha and others added 6 commits January 13, 2021 17:09
@tolusha
Update github-auth doc
90c241e 
Signed-off-by: Anatolii Bazko <abazko@redhat.com>
@tolusha
Fixes
c9572a8 
Signed-off-by: Anatolii Bazko <abazko@redhat.com>
@tolusha
Remove unused image
0039019 
Signed-off-by: Anatolii Bazko <abazko@redhat.com>
@themr0c @tolusha
Update modules/end-user-guide/partials/proc_configuring-github-oauth.…
61a345f 
…adoc
@tolusha @l0rd
Update modules/end-user-guide/partials/proc_configuring-github-oauth.…
16d825f 
…adoc

Co-authored-by: Mario Loriedo <mario.loriedo@gmail.com>
@tolusha @l0rd
Update modules/end-user-guide/partials/proc_configuring-github-oauth.…
be7dad2 
…adoc

Co-authored-by: Mario Loriedo <mario.loriedo@gmail.com>
tolusha and others added 8 commits January 13, 2021 17:09
@tolusha @l0rd
Update modules/end-user-guide/partials/proc_configuring-github-oauth.…
d32dcd4 
…adoc

Co-authored-by: Mario Loriedo <mario.loriedo@gmail.com>
@tolusha @l0rd
Update modules/end-user-guide/partials/proc_configuring-github-oauth.…
afa4cee 
…adoc

Co-authored-by: Mario Loriedo <mario.loriedo@gmail.com>
@tolusha @l0rd
Update modules/end-user-guide/partials/proc_configuring-github-oauth.…
2c99722 
…adoc

Co-authored-by: Mario Loriedo <mario.loriedo@gmail.com>
@tolusha @l0rd
Update modules/end-user-guide/partials/proc_configuring-github-oauth.…
18f6ae8 
…adoc

Co-authored-by: Mario Loriedo <mario.loriedo@gmail.com>
@tolusha @l0rd
Update modules/end-user-guide/partials/proc_configuring-github-oauth.…
7fc463a 
…adoc

Co-authored-by: Mario Loriedo <mario.loriedo@gmail.com>
@tolusha
Fix remarks
832ec7b 
Signed-off-by: Anatolii Bazko <abazko@redhat.com>
@tolusha
Move Configuring GitHub OAuth to Admin Guide
b3791e7 
Signed-off-by: Anatolii Bazko <abazko@redhat.com>
@tolusha
Add proc
298f009 
Signed-off-by: Anatolii Bazko <abazko@redhat.com>
@tolusha tolusha merged commit 478d1d1 into eclipse-che:master Jan 13, 2021
@tolusha tolusha deleted the mountsecrets branch January 13, 2021 15:18
sleshchenko pushed a commit to sleshchenko/che-docs that referenced this pull request Jan 22, 2021
@tolusha @themr0c
@l0rd @sleshchenko
Provision GitHub OAuth using secret (eclipse-che#1773)
7a4def9 
* Update github-auth doc

Signed-off-by: Anatolii Bazko <abazko@redhat.com>

Co-authored-by: Fabrice Flore-Thébault <ffloreth@redhat.com>
Co-authored-by: Mario Loriedo <mario.loriedo@gmail.com>
themr0c added a commit that referenced this pull request Mar 3, 2021
@themr0c
Revert "Provision GitHub OAuth using secret (#1773)" (#1880)
ee61f27 
This reverts commit 478d1d1.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@themr0c themr0c themr0c left review comments

@yhontyk yhontyk yhontyk approved these changes

@l0rd l0rd l0rd approved these changes

@vinokurig vinokurig Awaiting requested review from vinokurig

@MichalMaler MichalMaler Awaiting requested review from MichalMaler

@rkratky rkratky Awaiting requested review from rkratky

Assignees

@yhontyk yhontyk

Labels
kind/enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@tolusha @themr0c @yhontyk @l0rd @che-bot