Revert "Provision GitHub OAuth using secret (#1773)" #1880
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 478d1d1.
themr0c
requested review from
yhontyk,
MichalMaler,
rkratky and
a team
as code owners
|
@dmytro-ndp @tolusha I put this PR as WIP as long as we haven't decided if this feature needs rollback or not. |
|
It's a correct fix because describing feature is absent in Eclipse Che 7.24.x operator version https://github.com/eclipse/che-operator/commits/7.24.2: |
dmytro-ndp
approved these changes
Mar 2, 2021
tolusha
approved these changes
Mar 3, 2021
benoitf
approved these changes
Mar 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 478d1d1. That should not be in the 7.24.x branch.