Fix closing exec connections on che task SIGINT termination.

[AndrienkoAleksandr]

Referenced issue:

eclipse-che/che#14887

Fix closing exec connections on che task SIGINT termination.

Proposed changes: change image from scratch to busybox. Image will be bigger on 1.2Mb (26.7Mb against 25.5), but issue won't reproduces with this image.
P.S.: Alpine 3.10.2 works fine too, but image is bigger.

Signed-off-by: Oleksandr Andriienko oandriie@redhat.com

[benoitf]

it might be an issue for CRW as before it was scratch while now it's not rhel based

[benoitf]

what's the meaning of this instruction as we're in another image/container at runtime ?

[benoitf]

@AndrienkoAleksandr maybe there was a misunderstanding while I clicked on the line to report the question

it was about:

RUN adduser -D -g '' unprivilegeduser

instruction, not the update of golang

my question was, why do we add a user in the builder image as we don't use it on runtime ?

[AndrienkoAleksandr]

@benoitf why do we add a user in the builder image as we don't use it on runtime ?

Hello, we have a copy /etc/passwd to the builder image and define this user before start ENTRYPOINT. I take a look more and I see this stuff works only for docker. With openshift we used another user without username and this user in the root group. I think we can remove unprivilegeduser from dockerfile, because we really don't use it. What do you think?

[benoitf]

@AndrienkoAleksandr
yes now it is used because you added back the copy of /etc/passwd line
but when I commented, you removed the copy of etc/passwd file

[AndrienkoAleksandr]

but when I commented, you removed the copy of etc/passwd file

Sorry, yes, removing it was bad change.

[AndrienkoAleksandr]

Close on favor #54