Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sending Ctrl+C to one terminal widget kills all terminals #14887

Closed
RomanNikitenko opened this issue Oct 14, 2019 · 5 comments
Closed

Sending Ctrl+C to one terminal widget kills all terminals #14887

RomanNikitenko opened this issue Oct 14, 2019 · 5 comments
Assignees
Labels
area/machine-exec kind/bug Outline of a bug - must adhere to the bug report template. severity/P2 Has a minor but important impact to the usage or development of the system.

Comments

@RomanNikitenko
Copy link
Member

RomanNikitenko commented Oct 14, 2019

Describe the bug

I have faced issue from time to time when I'm developing che in che.

So I have one running instance of che and I run another instance from theia/examples/assembly.
After stopping a task by pressing Ctrl+C for one terminal widget all open terminals are killed.

Che version

Latest

Steps to reproduce

  1. Start workspace for che-in-che development
  2. Open few terminals for first instance of che
  3. Open few terminals for second instance of che
  4. Start any task (build of che-theia for example)
  5. Terminate the task by pressing Ctrl+C

You can see that all terminals (for first and second instance of che) are killed.

I didn't catch the cause of the problem and can not reproduce it permanently, but I have faced the issue from time to time when I'm developing che in che.

Please see the video: https://youtu.be/zvuwqC9bdAU

Expected behavior

Task is stopped after pressing Ctrl+C, other terminals are working.

Runtime

minikube (minikube version: v1.0.0)

Screenshots

https://youtu.be/zvuwqC9bdAU

Installation method

chectl chectl/0.0.2-5ab0061 linux-x64 node-v10.4.1

Environment

Linux

@RomanNikitenko RomanNikitenko added the kind/bug Outline of a bug - must adhere to the bug report template. label Oct 14, 2019
@che-bot che-bot added the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Oct 14, 2019
@RomanNikitenko
Copy link
Member Author

RomanNikitenko commented Oct 15, 2019

I played a lot with it and found how we can reproduce it: the issue is reproduced permanently if you send Ctrl+C twice for the same terminal widget of a task.

Update: it's enough to type any symbol to terminal widget for task which is completed or interrupted by ctrl+c to reproduce the issue.

@amisevsk
Copy link
Contributor

I've been able to reproduce this in the past, and it looks like the che-machine-exec container is being killed by the ctrl-c.

@l0rd l0rd added area/machine-exec team/ide2 severity/P2 Has a minor but important impact to the usage or development of the system. and removed status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. labels Oct 15, 2019
@AndrienkoAleksandr AndrienkoAleksandr self-assigned this Oct 31, 2019
@AndrienkoAleksandr AndrienkoAleksandr added the status/in-progress This issue has been taken by an engineer and is under active development. label Oct 31, 2019
@AndrienkoAleksandr AndrienkoAleksandr added status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. and removed status/in-progress This issue has been taken by an engineer and is under active development. labels Nov 4, 2019
@AndrienkoAleksandr AndrienkoAleksandr removed the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Nov 7, 2019
@AndrienkoAleksandr
Copy link
Contributor

AndrienkoAleksandr commented Nov 7, 2019

I reopen, because we found that we have two dockerfiles for che-machine-exec in the repo for two different CI. And one of them we should remove. I need to move fix to the correctly dockerfile...

@AndrienkoAleksandr
Copy link
Contributor

@AndrienkoAleksandr
Copy link
Contributor

Done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/machine-exec kind/bug Outline of a bug - must adhere to the bug report template. severity/P2 Has a minor but important impact to the usage or development of the system.
Projects
None yet
Development

No branches or pull requests

5 participants