This repository has been archived by the owner on Apr 4, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has failed:
|
E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has failed:
|
E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has failed:
|
Signed-off-by: Roman Nikitenko <rnikiten@redhat.com>
RomanNikitenko
force-pushed
the
stopTasks
branch
from
October 18, 2019 17:18
3b10673
to
919995e
Compare
E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has been successful:
|
RomanNikitenko
requested review from
AndrienkoAleksandr,
l0rd,
olexii4,
rhopp,
sunix,
vitaliy-guliy and
vparfonov
as code owners
October 21, 2019 09:39
Tested, works good. |
AndrienkoAleksandr
approved these changes
Oct 22, 2019
vinokurig
pushed a commit
that referenced
this pull request
Apr 6, 2021
* [release] Bump to 7.14.0 in 7.14.x Signed-off-by: Mykhailo Kuznietsov <mkuznets@redhat.com> * [release] Bump to 7.15.0-SNAPSHOT in master Signed-off-by: Mykhailo Kuznietsov <mkuznets@redhat.com> Co-authored-by: Mykhailo Kuznietsov <mkuznets@redhat.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add ability to stop
che
task by sendingctrl+c
to the corresponding terminal.User can use
Terminal => Terminate Task
action or close the corresponding terminal tab.See the video https://youtu.be/9u71j-Etg04
Please note there is the issue eclipse-che/che#14887 related to terminal widgets when task is completed or interrupted.
What issues does this PR fix or reference?
eclipse-che/che#13737
How to test
che
tasks, you can use the devfile as example:Devfile
The devfile contains the reference for
docker image: maxura/che-theia:489
related to the PRTerminal => Terminate Task
action or closing of the corresponding terminal tab to interrupt a task.Changelog
Add ability to stop
che
task by sendingctrl+c
to the corresponding terminal.Release Notes
Docs PR
Signed-off-by: Roman Nikitenko rnikiten@redhat.com