Skip to content
This repository has been archived by the owner on Apr 4, 2023. It is now read-only.

Add ability to stop running task #489

Merged
merged 1 commit into from
Oct 22, 2019
Merged

Add ability to stop running task #489

merged 1 commit into from
Oct 22, 2019

Conversation

RomanNikitenko
Copy link
Member

@RomanNikitenko RomanNikitenko commented Oct 15, 2019

What does this PR do?

Add ability to stop che task by sending ctrl+c to the corresponding terminal.
User can use Terminal => Terminate Task action or close the corresponding terminal tab.

See the video https://youtu.be/9u71j-Etg04

Please note there is the issue eclipse-che/che#14887 related to terminal widgets when task is completed or interrupted.

What issues does this PR fix or reference?

eclipse-che/che#13737

How to test

  1. Start any workspace with che tasks, you can use the devfile as example:
Devfile
apiVersion: 1.0.0
metadata:
 name: wksp-stop-tasks
projects:
  - name: che-theia
    source:
      type: git
      location: 'https://github.com/eclipse/che-theia.git'
  - name: theia
    source:
      type: git
      location: 'https://github.com/theia-ide/theia.git'
components:
  - 
    alias: che-dev
    type: dockerimage
    image: eclipse/che-theia-dev:next
    mountSources: true
    endpoints:
      - name: "theia-dev"
        port: 3130
        attributes:
          protocol: tcp
          public: 'true'
    memoryLimit: 4Gi
  - 
    alias: theia-editor
    reference: >-
      https://raw.githubusercontent.com/RomanNikitenko/che-plugin-registry/master/v3/plugins/eclipse/che-theia/custom/meta.yaml
    type: cheEditor
  
commands:
- name: theia:build
  actions:
  - type: exec
    component: che-dev
    command: >
              yarn
    workdir: /projects/theia

- name: che-theia:build
  actions:
  - type: exec
    component: che-dev
    command: >
              yarn
    workdir: /projects/che-theia

- name: test task
  actions:
  - type: exec
    component: che-dev
    command: >
              sleep 30 && echo test task is completed
    workdir: /projects/che-theia/plugins/task-plugin

The devfile contains the reference for docker image: maxura/che-theia:489 related to the PR

  1. Try to use Terminal => Terminate Task action or closing of the corresponding terminal tab to interrupt a task.
  2. Please try to stop a task after page refreshing.
  3. Note that there is the issue Sending Ctrl+C to one terminal widget kills all terminals  che#14887 related to terminal widgets when task is completed or interrupted.

Changelog

Add ability to stop che task by sending ctrl+c to the corresponding terminal.

Release Notes

Docs PR

Signed-off-by: Roman Nikitenko rnikiten@redhat.com

@che-bot
Copy link
Contributor

che-bot commented Oct 15, 2019

E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has failed:

@che-bot
Copy link
Contributor

che-bot commented Oct 15, 2019

E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has failed:

@che-bot
Copy link
Contributor

che-bot commented Oct 15, 2019

E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has failed:

Signed-off-by: Roman Nikitenko <rnikiten@redhat.com>
@che-bot
Copy link
Contributor

che-bot commented Oct 18, 2019

E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has been successful:

  • build details
  • logs and configs
  • "che-theia" docker image: maxura/che-theia:489
  • "che-theia-endpoint-runtime" docker image: maxura/che-theia-endpoint-runtime:489
  • "che-remote-plugin-runner-java8" docker image: maxura/che-remote-plugin-runner-java8:489
  • "che-remote-plugin-kubernetes-tooling-1.0.0" docker image: maxura/che-remote-plugin-kubernetes-tooling-1.0.0:489
  • Happy path tests DevFile

@AndrienkoAleksandr
Copy link
Contributor

Tested, works good.

@RomanNikitenko RomanNikitenko merged commit 8d932a2 into master Oct 22, 2019
@RomanNikitenko RomanNikitenko deleted the stopTasks branch October 22, 2019 12:53
vinokurig pushed a commit that referenced this pull request Apr 6, 2021
* [release] Bump to 7.14.0 in 7.14.x

Signed-off-by: Mykhailo Kuznietsov <mkuznets@redhat.com>

* [release] Bump to 7.15.0-SNAPSHOT in master

Signed-off-by: Mykhailo Kuznietsov <mkuznets@redhat.com>

Co-authored-by: Mykhailo Kuznietsov <mkuznets@redhat.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants