Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use nightly version che-machine-exec from centos Ci. (#290) #295

Merged
merged 2 commits into from
Nov 14, 2019
Merged

Use nightly version che-machine-exec from centos Ci. (#290) #295

merged 2 commits into from
Nov 14, 2019

Conversation

AndrienkoAleksandr
Copy link
Contributor

@AndrienkoAleksandr AndrienkoAleksandr commented Nov 13, 2019 •
edited
Loading

What does this PR do?

  • Use nightly version che-machine-exec from centos Ci.
    Use nightly version che-machine-exec from centos Ci.

Referenced issue

eclipse-che/che#14887

Signed-off-by: Oleksandr Andriienko oandriie@redhat.com

@ibuziuk
Copy link
Member

ibuziuk commented Nov 13, 2019

@AndrienkoAleksandr I'm worrying that this might have side-effects if the next version will not exist anymore in 7.3.x

@AndrienkoAleksandr
Use nightly version che-machine-exec from centos Ci. (#290)
0b8bd4b 
* Use nightly version che-machine-exec from centos Ci.
Use nightly version che-machine-exec from centos Ci.

Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>

* Fix up.

Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>
@AndrienkoAleksandr AndrienkoAleksandr force-pushed the useNightlyCheMachineExecWithCtrlCFix branch from 595bf3c to 0b8bd4b Compare November 13, 2019 10:31
@AndrienkoAleksandr
Copy link
Contributor Author

@AndrienkoAleksandr I'm worrying that this might have side-effects if the next version will not exist anymore in 7.3.x

Done I saved next tag.

@ibuziuk
Copy link
Member

ibuziuk commented Nov 13, 2019

@AndrienkoAleksandr maybe we should point to the nighly image from the next version of the plugin?

@AndrienkoAleksandr
Copy link
Contributor Author

AndrienkoAleksandr commented Nov 13, 2019 •
edited
Loading

@AndrienkoAleksandr maybe we should point to the nighly image from the next version of the plugin?

If it is ok for you, I can do it in this pr. Also I can mark next like deprecated.

@AndrienkoAleksandr
Add deprecation note for eclipse/che-machine-exec-plugin/next
42135ca 
Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>
@AndrienkoAleksandr
Copy link
Contributor Author

@ibuziuk maybe we should point to the nighly image from the next version of the plugin?
@AndrienkoAleksandr Also I can mark next like deprecated.

Done.

@ibuziuk
Copy link
Member

ibuziuk commented Nov 13, 2019

@amisevsk could you please take a look, I believe we should not have side effect for airgap

amisevsk
amisevsk approved these changes Nov 14, 2019
View reviewed changes
Copy link
Contributor

@amisevsk amisevsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AndrienkoAleksandr AndrienkoAleksandr merged commit efd73e8 into 7.3.x Nov 14, 2019
@AndrienkoAleksandr AndrienkoAleksandr deleted the useNightlyCheMachineExecWithCtrlCFix branch November 14, 2019 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ibuziuk ibuziuk ibuziuk approved these changes

@amisevsk amisevsk amisevsk approved these changes

@evidolob evidolob Awaiting requested review from evidolob

@vparfonov vparfonov Awaiting requested review from vparfonov vparfonov is a code owner

@l0rd l0rd Awaiting requested review from l0rd l0rd is a code owner

@nickboldt nickboldt Awaiting requested review from nickboldt nickboldt is a code owner

@rhopp rhopp Awaiting requested review from rhopp rhopp is a code owner

@skabashnyuk skabashnyuk Awaiting requested review from skabashnyuk skabashnyuk is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AndrienkoAleksandr @ibuziuk @amisevsk