Initial simple cloud-shell frontend #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>
AndrienkoAleksandr
requested review from
evidolob,
l0rd,
rhopp and
vparfonov
as code owners
3 tasks
l0rd
approved these changes
Dec 17, 2019
amisevsk
reviewed
Dec 18, 2019
Dockerfile
Outdated
| FROM scratch | ||
|
|
||
| COPY --from=builder /rootfs / | ||
| COPY --from=frontend-builder /cloud-shell /cloud-shell |
There was a problem hiding this comment.
Should the first /cloud-shell be ${DIST}? It seems that changing DIST would break the build.
azatsarynnyy
approved these changes
Dec 19, 2019
Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Referenced issue:
eclipse-che/che#15434
Proposed changes
Add simple cloud-shell frontend
Signed-off-by: Oleksandr Andriienko oandriie@redhat.com