Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Cloud shell terminal like Che editor. #326

Merged
merged 9 commits into from
Jan 29, 2020
Merged

Add Cloud shell terminal like Che editor. #326

merged 9 commits into from
Jan 29, 2020

Conversation

AndrienkoAleksandr
Copy link
Contributor

@AndrienkoAleksandr AndrienkoAleksandr commented Dec 17, 2019

What does this PR do?

Add Cloud shell terminal like Che editor.

It can be tested with the following Devfile:

metadata:
  name: cloud-shell
components:
  - reference: https://gist.githubusercontent.com/sleshchenko/c1cd908303b12684ac21e616c4cee1e9/raw/7e1dc5d106024af49fb1009af0c18792d2b1e328/meta.yaml
    type: cheEditor
    alias: cloudShell
  - memoryLimit: 256Mi
    type: dockerimage
    alias: dev
    image: 'eclipse/che-remote-plugin-openshift-connector-0.0.17:7.2.0'
    env:
      - value: '\[\e[34m\]>\[\e[m\]\[\e[33m\]>\[\e[m\]'
        name: PS1
apiVersion: 1.0.0

Referenced issue:

eclipse-che/che#15434
eclipse-che/che#15497

Depends on:

Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>
Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>
@sleshchenko sleshchenko changed the title Add Cloud shell terminal like Che editor. WIP Add Cloud shell terminal like Che editor. Jan 27, 2020
Copy link
Contributor

@amisevsk amisevsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just tested and it works with the provided devfile. One minor detail is that the first >> prompt appears on a separate line, indented deeply:
Screenshot from 2020-01-28 14-27-22

@sleshchenko
Copy link
Member

@amisevsk Sometimes it works fine for me
Screenshot_20200129_121758

Sometimes it just hangs and I don't get my terminal working... I'll register a separate issue for cloud shell

@sleshchenko sleshchenko changed the title WIP Add Cloud shell terminal like Che editor. Add Cloud shell terminal like Che editor. Jan 29, 2020
Copy link
Member

@sleshchenko sleshchenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CloudShell editor is not stable for me for some reasons but it's not related to the current PR, will register a separate issue for that.

BTW Well done!

@tolusha tolusha mentioned this pull request Jan 29, 2020
35 tasks
@sleshchenko sleshchenko merged commit d5f359f into master Jan 29, 2020
@sleshchenko sleshchenko deleted the cloud-shell branch January 29, 2020 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants