feat: Add ability to use internal network for Keycloak #507
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndrienkoAleksandr
requested review from
davidfestal,
nickboldt and
tolusha
as code owners
46 tasks
tolusha
reviewed
Oct 28, 2020
AndrienkoAleksandr
force-pushed
the
addAbilityToUseInternalNetworkForKeycloak
branch
from
76c5be2 to
f80872f
Compare
tolusha
reviewed
Nov 2, 2020
|
@davidfestal Could you review, please? |
davidfestal
reviewed
Nov 4, 2020
9 tasks
58 tasks
Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>
AndrienkoAleksandr
force-pushed
the
addAbilityToUseInternalNetworkForKeycloak
branch
from
b00e45a to
bf520ae
Compare
|
Pr is updated(I applied tests) and re-based. |
tolusha
approved these changes
Nov 26, 2020
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: AndrienkoAleksandr, tolusha The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
"Testing stable versions updates (pull_request)" - launched locally - passed. |
AndrienkoAleksandr
deleted the
addAbilityToUseInternalNetworkForKeycloak
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add ability to use internal network for keycloak.
What issues does this PR fix or reference?
eclipse-che/che#17644
Signed-off-by: Oleksandr Andriienko oandriie@redhat.com