Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to use internal network for keycloak. #18225

Merged
merged 3 commits into from
Nov 26, 2020

Conversation

AndrienkoAleksandr
Copy link
Contributor

@AndrienkoAleksandr AndrienkoAleksandr commented Oct 28, 2020

What does this PR do?

Add ability to use internal network for keycloak. Pr applies ability to use internal Keycloak url to make requests on the che-server. For user dashboard we provides public hostname url like earlier, because user dashboard is frontend and can't user internal network. We don't expose internal keycloak url though api, because this information is useful only for che-server now.

What issues does this PR fix or reference?

#17644

Related pr's:

Depends on eclipse-che/che-operator#507

How to test this PR?

PR Checklist

As the author of this Pull Request I made sure that:

Reviewers

Reviewers, please comment how you tested the PR when approving it.

Signed-off-by: Oleksandr Andriienko oandriie@redhat.com

@che-bot che-bot added status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. kind/enhancement A feature request - must adhere to the feature request template. labels Oct 28, 2020
@tolusha tolusha mentioned this pull request Oct 28, 2020
46 tasks
@che-bot
Copy link
Contributor

che-bot commented Oct 28, 2020

❌ E2E Happy path tests failed ❗

See Details

Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)

ℹ️ Use comment "[crw-ci-test]" to rerun happy path E2E test.

@che-bot
Copy link
Contributor

che-bot commented Nov 3, 2020

❌ E2E Happy path tests failed ❗

See Details

Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)

  • Use comment "[crw-ci-test]" to rerun happy path E2E test.
  • Use comment "[crw-ci-test --rebuild]" to re-build the images and rerun happy path E2E test.

@che-bot
Copy link
Contributor

che-bot commented Nov 10, 2020

❌ E2E Happy path tests failed ❗

See Details

Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)

  • Use comment "[crw-ci-test]" to rerun happy path E2E test.
  • Use comment "[crw-ci-test --rebuild]" to re-build the images and rerun happy path E2E test.

@artaleks9
Copy link
Contributor

@AndrienkoAleksandr Could you verify, that your PR is up to master branch?

@artaleks9
Copy link
Contributor

Ok, I see it helped.. the pr-checking goes. Thanks.

@che-bot
Copy link
Contributor

che-bot commented Nov 10, 2020

❌ E2E Happy path tests failed ❗

See Details

Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)

  • Use comment "[crw-ci-test]" to rerun happy path E2E test.
  • Use comment "[crw-ci-test --rebuild]" to re-build the images and rerun happy path E2E test.

@artaleks9
Copy link
Contributor

But there is some other trouble:

13:35:32 [06:35:28] → Failed to download image, reason: ErrImagePull, message: rpc error: code = Unknown desc = Error response from daemon: toomanyrequests: You have reached your pull rate limit. You may increase the limit by authenticating and upgrading: https://www.docker.com/increase-rate-limit.
13:35:32 [06:35:28] PostgreSQL pod bootstrap [failed]

QE-team needs to investigate it. It will take some time.

@artaleks9
Copy link
Contributor

artaleks9 commented Nov 10, 2020

It seems, it's related to #18292, and there is not much we can do other than..
Let's try to relaunch PR a bit later.

@artaleks9
Copy link
Contributor

@dmytro-ndp provided a workaround for this -> #18323
@AndrienkoAleksandr, please update your branch by the last changes from master - this will automatically relaunch PR check

Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>
Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>
Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>
@che-bot
Copy link
Contributor

che-bot commented Nov 10, 2020

❌ E2E Happy path tests failed ❗

See Details

Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)

  • Use comment "[crw-ci-test]" to rerun happy path E2E test.
  • Use comment "[crw-ci-test --rebuild]" to re-build the images and rerun happy path E2E test.

@sparkoo
Copy link
Member

sparkoo commented Nov 10, 2020

@dmytro-ndp provided a workaround for this -> #18323

Is it only increasing the limit to 200/6hr or do the used account has actually some dockerhub subscription?

@artaleks9
Copy link
Contributor

@AndrienkoAleksandr Could you verify/confirm that commit is in your branch?

@AndrienkoAleksandr
Copy link
Contributor Author

@artaleks9: @AndrienkoAleksandr Could you verify/confirm that commit is in your branch?

Yes, I have this commit.

@artaleks9
Copy link
Contributor

Thanks, in this case, probably the workaround didn't help ((
I'm relaunching your PR, let's try again..

@artaleks9
Copy link
Contributor

[crw-ci-test]

@che-bot
Copy link
Contributor

che-bot commented Nov 11, 2020

❌ E2E Happy path tests failed ❗

See Details

Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)

  • Use comment "[crw-ci-test]" to rerun happy path E2E test.
  • Use comment "[crw-ci-test --rebuild]" to re-build the images and rerun happy path E2E test.

@artaleks9
Copy link
Contributor

So, Happy-path was fail, but it's a known issue (#18034)
From my side there are no objections to merge.

@tolusha tolusha mentioned this pull request Nov 16, 2020
58 tasks
@AndrienkoAleksandr
Copy link
Contributor Author

@skabashnyuk Could you take a look this pr?

@AndrienkoAleksandr AndrienkoAleksandr merged commit 4100db3 into master Nov 26, 2020
@AndrienkoAleksandr AndrienkoAleksandr deleted the keycloakInternalNetwork branch November 26, 2020 15:27
@che-bot che-bot removed the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Nov 26, 2020
@sleshchenko sleshchenko mentioned this pull request Jan 14, 2021
22 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement A feature request - must adhere to the feature request template.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants