-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ability to use internal network for keycloak. #18225
Conversation
❌ E2E Happy path tests failed ❗ See Details
Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1) ℹ️ |
...eycloak-server/src/main/java/org/eclipse/che/multiuser/keycloak/server/KeycloakSettings.java
Show resolved
Hide resolved
...eycloak-server/src/main/java/org/eclipse/che/multiuser/keycloak/server/KeycloakSettings.java
Outdated
Show resolved
Hide resolved
...eycloak-server/src/main/java/org/eclipse/che/multiuser/keycloak/server/KeycloakSettings.java
Outdated
Show resolved
Hide resolved
...eycloak-server/src/main/java/org/eclipse/che/multiuser/keycloak/server/KeycloakSettings.java
Show resolved
Hide resolved
❌ E2E Happy path tests failed ❗ See Details
Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)
|
❌ E2E Happy path tests failed ❗ See Details
Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)
|
@AndrienkoAleksandr Could you verify, that your PR is up to master branch? |
c5c73a3
to
423b51c
Compare
Ok, I see it helped.. the pr-checking goes. Thanks. |
❌ E2E Happy path tests failed ❗ See Details
Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)
|
But there is some other trouble:
QE-team needs to investigate it. It will take some time. |
It seems, it's related to #18292, and there is not much we can do other than.. |
@dmytro-ndp provided a workaround for this -> #18323 |
Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>
Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>
Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>
423b51c
to
da40983
Compare
❌ E2E Happy path tests failed ❗ See Details
Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)
|
Is it only increasing the limit to 200/6hr or do the used account has actually some dockerhub subscription? |
@AndrienkoAleksandr Could you verify/confirm that commit is in your branch? |
Yes, I have this commit. |
Thanks, in this case, probably the workaround didn't help (( |
[crw-ci-test] |
❌ E2E Happy path tests failed ❗ See Details
Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)
|
So, |
@skabashnyuk Could you take a look this pr? |
What does this PR do?
Add ability to use internal network for keycloak. Pr applies ability to use internal Keycloak url to make requests on the che-server. For user dashboard we provides public hostname url like earlier, because user dashboard is frontend and can't user internal network. We don't expose internal keycloak url though api, because this information is useful only for che-server now.
What issues does this PR fix or reference?
#17644
Related pr's:
Depends on eclipse-che/che-operator#507
How to test this PR?
PR Checklist
As the author of this Pull Request I made sure that:
What issues does this PR fix or reference
andHow to test this PR
completedReviewers
Reviewers, please comment how you tested the PR when approving it.
Signed-off-by: Oleksandr Andriienko oandriie@redhat.com