Authentication flow doesn't work

[vinokurig]

Describe the bug

Authentication popup cant reach the keycloak API.

Che version

• latest
• nightly
• other: please specify

Steps to reproduce

1. In the dashboard create a workspace.
2. Go to the projects tab and click Add Project button.
3. Chose GitHub and click the Connect your GitHub account button.

See: A popup with unavailable address is shown:

Expected behavior

The popup should open the redirected url from keycloak.

Runtime

• kubernetes (include output of kubectl version)
• Openshift (include output of oc version)
• minikube (include output of minikube version and kubectl version)
• minishift (include output of minishift version and oc version)
• docker-desktop + K8S (include output of docker version and kubectl version)
• other: (please specify)

Screenshots

Installation method

• chectl
  • provide a full command that was used to deploy Eclipse Che (including the output)
  • provide an output of chectl version command
• OperatorHub
• I don't know

Environment

• my computer
  • Windows
  • Linux
  • macOS
• Cloud
  • Amazon
  • Azure
  • GCE
  • other (please specify)
• other: please specify

Eclipse Che Logs

Additional context

[benoitf]

@vinokurig as dashboard is switching over to dashboard-next maybe there is no longer this issue (if login is no longer there)
cc @sleshchenko

[vinokurig]

@benoitf The issue is not related to dashboard, It can be reproduced from a workspace by signing in GitHub pull-request plugin or other plugins that use GitHub e.g. Git or SSH plugin. I mentioned dashboard as it is the easiest way to reproduce the problem.

[tolusha]

Everything should work for GitHub PR plugin
eclipse-che/che-theia#953

[tolusha]

I tend to think it is just a dashboard issue.

[benoitf]

@vinokurig the flow you're describing in the issue is specific to the dashboard (there is no server code involved)

[sleshchenko]

as dashboard is switching over to dashboard-next maybe there is no longer this issue (if login is no longer there)

that's true. New Dashboard does not have this functionality yet. This issue will be fixed by our team only in case it's a critical for CRW.

[vinokurig]

@benoitf @tolusha

Everything should work for GitHub PR plugin

Actually it doesn't work because the authentication request is called here: https://github.com/eclipse/che/blob/f9d8638acb0d75daf72dae1a38463768df778f54/assembly/assembly-root-war/src/main/webapp/_app/oauthLoader.js#L160-L164

[vinokurig]

Even when I do the request manually with the API url from the CHE_API_EXTERNAL env variable:

https://che-che.192.168.99.254.nip.io/api/oauth/authenticate?oauth_provider=github&redirect_after_login=https://che-che.192.168.99.254.nip.io&scope=repo&token=<user token>

it doesn't work.

[vinokurig]

@benoitf

@vinokurig the flow you're describing in the issue is specific to the dashboard (there is no server code involved)

The server side is involved because the popup calls the server API which is redirecting to an unavailable url.

[sleshchenko]

Seems there is nothing Dashboard does with it. Probably it's related to #18225 and somewhere internal URL is used, but publish must be.