Fix account linking url for frontend. #18815
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndrienkoAleksandr
requested review from
mshaposhnik and
nickboldt
as code owners
che-bot
added
status/code-review
|
❌ E2E Happy path tests failed ❗ See Details
Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)
|
|
[crw-ci-test] |
|
❌ E2E Happy path tests failed ❗ See Details
Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)
|
skabashnyuk
approved these changes
Jan 18, 2021
Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>
AndrienkoAleksandr
force-pushed
the
fixAccountLinkingUrlForFrontend
branch
from
87b6bac to
cccad0e
Compare
|
I rebased pr. Maybe it's somehow will help CI... |
|
SonarCloud Quality Gate failed. |
|
✅ E2E Happy path tests succeed 🎉 See Details
Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)
|
|
I referenced Sonar lint proposal to the separated issue #18818 |
|
Tested. It works. |
tolusha
approved these changes
Jan 18, 2021
che-bot
removed
the
status/code-review
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Oleksandr Andriienko oandriie@redhat.com
What does this PR do?
Fix account linking url for frontend.
What issues does this PR fix or reference?
#18791
How to test this PR?
Install Eclipse Che with help of chectl using
operatororOLMinstaller. Set up github oAuth: https://www.eclipse.org/che/docs/che-7/administration-guide/configuring-authorization/#configuring-github-oauth_che. Add project to the devfile using user dashboard: how to do that described in the issue: #18791PR Checklist
As the author of this Pull Request I made sure that:
What issues does this PR fix or referenceandHow to test this PRcompletedReviewers
Reviewers, please comment how you tested the PR when approving it.