-
Notifications
You must be signed in to change notification settings - Fork 26
Conversation
@ibuziuk FYI |
@garagatyi any instructions how we could try a new broker ? |
Signed-off-by: Oleksandr Garagatyi <ogaragat@redhat.com>
@ibuziuk Full-blown approach would be hard to try. I suppose that not everything is ready to handle this situation, but I'm not sure. I tried a partial approach with a custom main method that parses a local config.json file. To test you'll need to:
|
995db2a
to
946fc62
Compare
Signed-off-by: Oleksandr Garagatyi <ogaragat@redhat.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally looks OK for me.
Please take a look and fix/answer my inline comments and notify me - will do final review.
Signed-off-by: Oleksandr Garagatyi <ogaragat@redhat.com>
Signed-off-by: Oleksandr Garagatyi <ogaragat@redhat.com>
Signed-off-by: Oleksandr Garagatyi <ogaragat@redhat.com>
Signed-off-by: Oleksandr Garagatyi <ogaragat@redhat.com>
Signed-off-by: Oleksandr Garagatyi <ogaragat@redhat.com>
@ibuziuk @sleshchenko Please, review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Oleksandr Garagatyi <ogaragat@redhat.com>
@garagatyi are those instructions up-to-date - #19 (comment) or there is now better approach for trying this PR ? |
@ibuziuk yes, but kubectl extension won't work in any case. But you can try something else, like Sonarlint |
@ibuziuk @skabashnyuk @AndrienkoAleksandr please provide review if you will |
Use of Theia 0.3.14
What does this PR do?
VS Code extension broker.
Dockerfile for container image:
Example of meta.yaml for kubernetes extension:
What issues does this PR fix or reference?