Skip to content
This repository has been archived by the owner on Jan 20, 2023. It is now read-only.

Add VSCode extension broker #19

Merged
merged 21 commits into from
Jan 10, 2019
Merged

Add VSCode extension broker #19

merged 21 commits into from
Jan 10, 2019

Conversation

garagatyi
Copy link

@garagatyi garagatyi commented Dec 7, 2018

What does this PR do?

VS Code extension broker.

Dockerfile for container image:

FROM wsskeleton/theia-endpoint-runtime
WORKDIR /usr/local/bin
RUN wget https://storage.googleapis.com/kubernetes-release/release/v1.8.11/bin/linux/amd64/kubectl && chmod +x ./kubectl
RUN mkdir /.kube && chmod g+w /.kube

Example of meta.yaml for kubernetes extension:

id: vscode-k8s-ext
version: 0.0.1
type: Theia plugin
name: Vscode k8s plugin
title: k8s extension
description: k8s extension
icon: https://www.eclipse.org/che/images/ico/16x16.png
attributes:
  extension: "vscode:extension/ms-kubernetes-tools.vscode-kubernetes-tools"
  container-image: "garagatyi/remotetheia:kubectl"

What issues does this PR fix or reference?

@garagatyi
Copy link
Author

@ibuziuk FYI

@ibuziuk
Copy link
Member

ibuziuk commented Dec 10, 2018

@garagatyi any instructions how we could try a new broker ?

Oleksandr Garagatyi added 2 commits December 10, 2018 17:04
Signed-off-by: Oleksandr Garagatyi <ogaragat@redhat.com>
@garagatyi
Copy link
Author

@ibuziuk Full-blown approach would be hard to try. I suppose that not everything is ready to handle this situation, but I'm not sure. I tried a partial approach with a custom main method that parses a local config.json file.
I also tried it with Theia but extension didn't work properly even though the kubernetes panel was added to Theia. I think it was considered as a local plugin rather than a remote one.

To test you'll need to:

  1. Apply this PR Add attributes to Che 7 plugin meta; make URL field not mandatory che#12148
  2. Build the broker.
  3. Add a plugin to plugin registry WIP Add VS Code k8s extension che-plugin-registry#66
  4. Create workspace with this plugin enabled and start it.
  5. Login to kubernetes using kubectl command from a terminal to create kube context.

@garagatyi garagatyi force-pushed the vscodebroker branch 2 times, most recently from 995db2a to 946fc62 Compare December 11, 2018 01:04
Oleksandr Garagatyi added 2 commits December 27, 2018 10:28
Signed-off-by: Oleksandr Garagatyi <ogaragat@redhat.com>
@garagatyi garagatyi changed the title WIP Add VSCode extension broker Add VSCode extension broker Dec 27, 2018
Dockerfile.veb Outdated Show resolved Hide resolved
Copy link
Member

@sleshchenko sleshchenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks OK for me.

Please take a look and fix/answer my inline comments and notify me - will do final review.

brokers/vscode/broker_test.go Outdated Show resolved Hide resolved
brokers/vscode/broker.go Show resolved Hide resolved
brokers/vscode/broker_test.go Show resolved Hide resolved
brokers/vscode/cmd/main.go Show resolved Hide resolved
brokers/vscode/broker.go Outdated Show resolved Hide resolved
brokers/vscode/broker.go Outdated Show resolved Hide resolved
brokers/vscode/broker.go Outdated Show resolved Hide resolved
brokers/vscode/broker.go Show resolved Hide resolved
brokers/vscode/broker.go Outdated Show resolved Hide resolved
brokers/vscode/broker.go Outdated Show resolved Hide resolved
Oleksandr Garagatyi added 10 commits December 28, 2018 16:45
Signed-off-by: Oleksandr Garagatyi <ogaragat@redhat.com>
Signed-off-by: Oleksandr Garagatyi <ogaragat@redhat.com>
Signed-off-by: Oleksandr Garagatyi <ogaragat@redhat.com>
Signed-off-by: Oleksandr Garagatyi <ogaragat@redhat.com>
Signed-off-by: Oleksandr Garagatyi <ogaragat@redhat.com>
Signed-off-by: Oleksandr Garagatyi <ogaragat@redhat.com>
Signed-off-by: Oleksandr Garagatyi <ogaragat@redhat.com>
@slemeur slemeur mentioned this pull request Jan 3, 2019
69 tasks
@garagatyi
Copy link
Author

@ibuziuk @sleshchenko Please, review

Copy link
Member

@sleshchenko sleshchenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

.gitignore Show resolved Hide resolved
brokers/vscode/broker.go Outdated Show resolved Hide resolved
Oleksandr Garagatyi added 2 commits January 9, 2019 09:09
Signed-off-by: Oleksandr Garagatyi <ogaragat@redhat.com>
@ibuziuk
Copy link
Member

ibuziuk commented Jan 9, 2019

@garagatyi are those instructions up-to-date - #19 (comment) or there is now better approach for trying this PR ?

@garagatyi
Copy link
Author

@ibuziuk yes, but kubectl extension won't work in any case. But you can try something else, like Sonarlint

@garagatyi
Copy link
Author

@ibuziuk @skabashnyuk @AndrienkoAleksandr please provide review if you will

README.md Outdated Show resolved Hide resolved
Oleksandr Garagatyi added 3 commits January 9, 2019 17:41
Signed-off-by: Oleksandr Garagatyi <ogaragat@redhat.com>
Signed-off-by: Oleksandr Garagatyi <ogaragat@redhat.com>
Fix
Signed-off-by: Oleksandr Garagatyi <ogaragat@redhat.com>
@garagatyi garagatyi merged commit 9089678 into master Jan 10, 2019
@garagatyi garagatyi deleted the vscodebroker branch January 10, 2019 11:42
metlos pushed a commit to metlos/che-plugin-broker that referenced this pull request Jun 17, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants