Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add binding of VS Code extension broker for Che 7 #12149

Merged
merged 6 commits into from
Jan 10, 2019
Merged

Add binding of VS Code extension broker for Che 7 #12149

merged 6 commits into from
Jan 10, 2019

Conversation

garagatyi
Copy link

@garagatyi garagatyi commented Dec 7, 2018 •
edited
Loading

What does this PR do?

Adds binding of VS Code extension broker.
Demo of adding Sonarlint extension to Che https://youtu.be/5RLLs5J4qdg

What issues does this PR fix or reference?

eclipse-che/che-plugin-broker#19
eclipse-che/che-plugin-registry#66
#12292

Release Notes

Docs PR

Add binding of VS Code extension broker for Che 7
8e3e53a 
Signed-off-by: Oleksandr Garagatyi <ogaragat@redhat.com>
@benoitf benoitf added the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Dec 7, 2018
@garagatyi garagatyi mentioned this pull request Dec 11, 2018
Closed
@garagatyi garagatyi mentioned this pull request Dec 20, 2018
Closed
@garagatyi
Copy link
Author

@l0rd @ibuziuk I checked VS Code broker and it seems to work now, but target extension that manages kubernetes doesn't work. See details #12292

@garagatyi
Copy link
Author

Added demo of Sonarlint remote plugin in Che to issue description https://youtu.be/5RLLs5J4qdg

@slemeur slemeur mentioned this pull request Jan 3, 2019
Closed
69 tasks
@ibuziuk
Copy link
Member

ibuziuk commented Jan 7, 2019

@garagatyi are you planning to postpone merge until #12292 is resolved ?

@garagatyi
Copy link
Author

@ibuziuk no, this PR allows running extensions that do not execute commands, such as Sonarlint.

@garagatyi garagatyi mentioned this pull request Jan 8, 2019
Closed
@garagatyi garagatyi changed the title WIP Add binding of VS Code extension broker for Che 7 Add binding of VS Code extension broker for Che 7 Jan 10, 2019
@ibuziuk ibuziuk self-requested a review January 10, 2019 12:04
@garagatyi
Copy link
Author

ci-test

@che-bot
Copy link
Contributor

che-bot commented Jan 10, 2019

Results of automated E2E tests of Eclipse Che Multiuser on OCP:
Build details
Test report
docker image: eclipseche/che-server:12149
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

@garagatyi
Copy link
Author

Since this PR only adds new broker and doesn't change work of anything else I decided to merge PR without analyzing functional tests results.

@garagatyi garagatyi merged commit 72065b5 into eclipse-che:master Jan 10, 2019
@garagatyi garagatyi deleted the vscodeBroker2 branch January 10, 2019 19:09
@benoitf benoitf added this to the 6.17.0 milestone Jan 14, 2019
@benoitf benoitf added kind/enhancement A feature request - must adhere to the feature request template. and removed status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. labels Jan 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@l0rd l0rd l0rd approved these changes

@ibuziuk ibuziuk ibuziuk approved these changes

@skabashnyuk skabashnyuk skabashnyuk approved these changes

@sleshchenko sleshchenko sleshchenko approved these changes

@riuvshin riuvshin Awaiting requested review from riuvshin

Assignees
No one assigned
Labels
kind/enhancement A feature request - must adhere to the feature request template.
Projects
None yet
Milestone
6.17.0
Development

Successfully merging this pull request may close these issues.
7 participants
@garagatyi @ibuziuk @che-bot @l0rd @skabashnyuk @sleshchenko @benoitf