Release 7.3.1 version of che-plugin-registry #275

ibuziuk · 2019-10-28T16:50:00Z

What does this PR do?

Cherry-picking all commits from master
Bumping version to 7.3.1
Adding 7.3.1 versions of 'che-theia' and 'che-machine-exec' and updating latest.txt of those plugins
Setting '7.3.1' version for container runtime images of the che remote plugins via find . -name '*.yaml' -exec sed -i -e 's/:7.3.0/:7.3.1/g' {} \;

What issue does this PR reffer to?

…e Hosted Che deployment Signed-off-by: Ilya Buziuk <ibuziuk@redhat.com>

…ipse-che#258) Change-Id: I9ae20399c599912d4f73a22d8c23a588d45d0bca Signed-off-by: nickboldt <nboldt@redhat.com>

…ns of che-theia and machine-exec plugins and updating 'latest' versions of those plugins to '7.3.0'. Fixing 'latest' verison of the che-machine-exec (updating description, adding 'secure' and 'cookiesAuthEnabled' attributes, formatting) Signed-off-by: Ilya Buziuk <ibuziuk@redhat.com>

Signed-off-by: Masaki Muranaka <monaka@monami-ya.com>

….0.4 (eclipse-che#256) * Add Kubernetes Che Plugin based on the VS Code Kubernetes extension 1.0.4 Signed-off-by: Artem Zatsarynnyi <azatsary@redhat.com> * Point k8s plugin latest version to 1.0.4 Signed-off-by: Artem Zatsarynnyi <azatsary@redhat.com>

Signed-off-by: Masaki Muranaka <monaka@monami-ya.com>

…clipse-che#265) To aid in deploying Che in an offline scenario, it's necessary to have a list of images used in plugins. Signed-off-by: Angel Misevski <amisevsk@redhat.com>

By default, the plugin registry redirects requests at /plugins to /v3/plugins. This commit adds a similar redirect for /resources (to /v3/resources) to avoid obtuse errors when running an offline registry. Signed-off-by: Angel Misevski <amisevsk@redhat.com>

* Remove latest meta.yamls, add latest.version files for each plugin Signed-off-by: Angel Misevski <amisevsk@redhat.com>

…o registry.access.redhat.com/rhscl/httpd-24-rhel7:2.4-105 (eclipse-che#268) Change-Id: Ieeec90d0be83c93743affb8c191c238b44952920 Signed-off-by: nickboldt <nboldt@redhat.com>

…est = 1.0.4 (eclipse-che#269) Change-Id: If8cf268e7bca01e909fd96a4625b0c7d84afddba Signed-off-by: nickboldt <nboldt@redhat.com>

* Add init container to inject remote binary. Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com> * Fix up Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com> * Fix image organization. Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com> * Use settings.xml patching for java images. Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com> * Fix up. Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com> * Use 'entrypoint.sh' script to start remote plugin binary Signed-off-by: Yevhen Vydolob <yvydolob@redhat.com> * Apply all oc 0.21 dependencies. Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com> * Apply all needed dependencies for oc-connector. Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com> * Don't change command for all versions Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com> * Start befo-start.sh for java 0.50.0 Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com> * Don't override entrypoint. Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>

The regex we use to update image references used in airgap mode fails if the registry hostname contains a colon. Signed-off-by: Angel Misevski <amisevsk@redhat.com>

… to run in offline-builder phase and WON'T RUN in Brew unless we copy the script to registry image too -- and this is simpler for Che, CRW, and Brew flavours) (eclipse-che#271) Change-Id: Ie1380a05c7eebc1f0b3ba8d5ec9c8149345953db Signed-off-by: nickboldt <nboldt@redhat.com> move ./list_referenced_images.sh to builder (from offline-builder); remove -c from rhel.Dockerfile so it's consistent with Dockerfile Change-Id: Ied3d0d977c7d8dc379d66ff715bbb394ecd1ea58 Signed-off-by: nickboldt <nboldt@redhat.com>

Signed-off-by: Ilya Buziuk <ibuziuk@redhat.com>

…' plugins. Updating 'latest.txt' file for those plugins Signed-off-by: Ilya Buziuk <ibuziuk@redhat.com>

…e che remote plugins Signed-off-by: Ilya Buziuk <ibuziuk@redhat.com>

nickboldt · 2019-10-28T16:58:16Z

v3/plugins/redhat/vscode-openshift-connector/0.1.0/meta.yaml

      name: "vscode-openshift-connector"
      memoryLimit: "512Mi"
  extensions:
+    - https://github.com/Azure/vscode-kubernetes-tools/releases/download/1.0.0/vscode-kubernetes-tools-1.0.0.vsix


why are these added?

because those are in master, no ?

ah, it's 097a56f

so if 097a56f#diff-525d44ea1d1f41ad8ca64916cc13850aR70 is for /next/ does that mean it's not applicable to 7.3.1 ? or does the release process copy v3/plugins/eclipse/che-theia/next/meta.yaml to v3/plugins/eclipse/che-theia/7.3.1/meta.yaml ?

@nickboldt my understanding that this PR #233 is addressing eclipse-che/che#14797 at some point, so it must be in 7.3.1
@AndrienkoAleksandr @evidolob could you comment?

nickboldt

148 files reviewed: just one question about why two new plugins were added to the openshift connnector meta.yaml. I don't remember seeing that in master branch.

amisevsk

Generally LGTM, with a few comments.

Also, I don't know our policy on adding new plugins to a bugfix release, but the following plugins are present in this PR but not in 7.3.0:

/v3/plugins/pizzafactory/xtend-lang
./v3/plugins/pizzafactory/vscode-libra-move
./v3/plugins/pizzafactory/xtext-lang

amisevsk · 2019-10-28T17:31:27Z

v3/plugins/eclipse/che-theia/7.3.1/meta.yaml

-title: Eclipse Theia for Eclipse Che
-description: Eclipse Theia
+title: Eclipse Theia development version.
+description: Eclipse Theia, get the latest release each day.


This title and description seems to be inaccurate, no? The version will be fixed here.

amisevsk · 2019-10-28T17:32:30Z

v3/plugins/ms-kubernetes-tools/vscode-kubernetes-tools/1.0.4/meta.yaml

-  - image: "docker.io/eclipse/che-remote-plugin-kubernetes-tooling-1.0.0:7.3.0"
-    name: vscode-kubernetes-tools
-    memoryLimit: "1G"
+    - image: "docker.io/eclipse/che-remote-plugin-kubernetes-tooling-1.0.4:next"


Should be tagged 7.3.1? This is the "latest" version.

@amisevsk good catch, I assume if we would like to keep pizzafactory plugins in 7.3.1 the container runtime image should be also updated there

👍 @monaka any issues with this?

ibuziuk · 2019-10-28T17:43:02Z

Also, I don't know our policy on adding new plugins to a bugfix release, but the following plugins are present in this PR but not in 7.3.0:

/v3/plugins/pizzafactory/xtend-lang
./v3/plugins/pizzafactory/vscode-libra-move
./v3/plugins/pizzafactory/xtext-lang

@nickboldt @l0rd I'm also not sure if we should keep it or remove of 7.3.1

Signed-off-by: Ilya Buziuk <ibuziuk@redhat.com>

…ernetes-tools plugin Signed-off-by: Ilya Buziuk <ibuziuk@redhat.com>

l0rd · 2019-10-28T18:03:50Z

@ibuziuk we should probably remove them. If that's complicated let's discuss it.

amisevsk · 2019-10-28T18:08:01Z

There should be no harm in just rm -rfing those directories; I agree we should wait until 7.4.0 to introduce them.

Signed-off-by: Ilya Buziuk <ibuziuk@redhat.com>

ibuziuk · 2019-10-28T18:15:42Z

@amisevsk @nickboldt @l0rd PR has been updated - addressed Angel's review comments + removed pizzafactory plugins

ibuziuk and others added 18 commits October 21, 2019 16:38

Adding openshift template for backwards compatibility required for th…

5742015

…e Hosted Che deployment Signed-off-by: Ilya Buziuk <ibuziuk@redhat.com>

allow check_plugins_viewer_mandatory_fields.sh to be run locally (ecl…

11710f3

…ipse-che#258) Change-Id: I9ae20399c599912d4f73a22d8c23a588d45d0bca Signed-off-by: nickboldt <nboldt@redhat.com>

Use string value at env.value instead of boolean or integer.

ae505e2

Signed-off-by: Masaki Muranaka <monaka@monami-ya.com>

Add language supports for Xtext/Xtend.

7bbf761

Signed-off-by: Masaki Muranaka <monaka@monami-ya.com>

Add LS for Move by Libra

71e059e

Signed-off-by: Masaki Muranaka <monaka@monami-ya.com>

Add list of external images to server when offline registry is built (e…

55037f5

…clipse-che#265) To aid in deploying Che in an offline scenario, it's necessary to have a list of images used in plugins. Signed-off-by: Angel Misevski <amisevsk@redhat.com>

Update how latest versions of plugins are handled (eclipse-che#260)

5ca46d4

* Remove latest meta.yamls, add latest.version files for each plugin Signed-off-by: Angel Misevski <amisevsk@redhat.com>

update from registry.access.redhat.com/rhscl/httpd-24-rhel7:2.4-104 t…

329deb7

…o registry.access.redhat.com/rhscl/httpd-24-rhel7:2.4-105 (eclipse-che#268) Change-Id: Ieeec90d0be83c93743affb8c191c238b44952920 Signed-off-by: nickboldt <nboldt@redhat.com>

move up to v3/plugins/ms-kubernetes-tools/vscode-kubernetes-tools lat…

f92d8dc

…est = 1.0.4 (eclipse-che#269) Change-Id: If8cf268e7bca01e909fd96a4625b0c7d84afddba Signed-off-by: nickboldt <nboldt@redhat.com>

Fix regex used for processing image references (eclipse-che#272)

247baf9

The regex we use to update image references used in airgap mode fails if the registry hostname contains a colon. Signed-off-by: Angel Misevski <amisevsk@redhat.com>

che #14947 Bumping version to 7.3.1

0bf7f15

Signed-off-by: Ilya Buziuk <ibuziuk@redhat.com>

che #14947 Adding 7.3.1 versions of 'che-theia' and 'che-machine-exec…

dda0aec

…' plugins. Updating 'latest.txt' file for those plugins Signed-off-by: Ilya Buziuk <ibuziuk@redhat.com>

che #14947 Setting '7.3.1' version for container runtime images of th…

b74bffc

…e che remote plugins Signed-off-by: Ilya Buziuk <ibuziuk@redhat.com>

ibuziuk requested review from amisevsk, l0rd, nickboldt, rhopp, skabashnyuk and vparfonov as code owners October 28, 2019 16:50

nickboldt reviewed Oct 28, 2019

View reviewed changes

nickboldt approved these changes Oct 28, 2019

View reviewed changes

l0rd mentioned this pull request Oct 28, 2019

Release Che v7.3.1 eclipse-che/che#14947

Closed

30 tasks

ibuziuk requested review from evidolob and AndrienkoAleksandr October 28, 2019 17:11

amisevsk approved these changes Oct 28, 2019

View reviewed changes

ibuziuk added 2 commits October 28, 2019 18:51

Updating title & description of the '7.3.1' version of che-theia

45bb005

Signed-off-by: Ilya Buziuk <ibuziuk@redhat.com>

Setting '7.3.1' version of the container runtime image for vscode-kub…

869da1b

…ernetes-tools plugin Signed-off-by: Ilya Buziuk <ibuziuk@redhat.com>

Excluding 'pizzafactory' plugins from the '7.3.1' release

03a07d0

Signed-off-by: Ilya Buziuk <ibuziuk@redhat.com>

amisevsk approved these changes Oct 28, 2019

View reviewed changes

ibuziuk merged commit ab01e8f into eclipse-che:7.3.x Oct 28, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Release 7.3.1 version of che-plugin-registry #275

Release 7.3.1 version of che-plugin-registry #275

ibuziuk commented Oct 28, 2019

nickboldt Oct 28, 2019

ibuziuk Oct 28, 2019

ibuziuk Oct 28, 2019

nickboldt Oct 28, 2019

nickboldt Oct 28, 2019 •

edited

Loading

ibuziuk Oct 28, 2019

nickboldt left a comment

amisevsk left a comment

amisevsk Oct 28, 2019

ibuziuk Oct 28, 2019

amisevsk Oct 28, 2019

ibuziuk Oct 28, 2019

amisevsk Oct 28, 2019

ibuziuk commented Oct 28, 2019

l0rd commented Oct 28, 2019

amisevsk commented Oct 28, 2019

ibuziuk commented Oct 28, 2019

Release 7.3.1 version of che-plugin-registry #275

Release 7.3.1 version of che-plugin-registry #275

Conversation

ibuziuk commented Oct 28, 2019

What does this PR do?

What issue does this PR reffer to?

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

nickboldt Oct 28, 2019 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

nickboldt left a comment

Choose a reason for hiding this comment

amisevsk left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ibuziuk commented Oct 28, 2019

l0rd commented Oct 28, 2019

amisevsk commented Oct 28, 2019

ibuziuk commented Oct 28, 2019

nickboldt Oct 28, 2019 •

edited

Loading