-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create tests to check 'Git zero-config' flow as PR checks #494
Conversation
/retest |
@artaleks9 : do you have logs of successful and failed PR check execution to share? It's also not clear which particular scenario the test is executing:
|
Updated: I can carefully say, it seems, there is possible to execute setup PAT and check appropriate clone a public/private repository already with PAT. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@artaleks9: thanks for the answers! |
@artaleks9 @dmytro-ndp folks, can we merge this PR now? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to merge.
The last updates includes:
|
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
New changes look good to merge.
Thanks for the handling feedback, @artaleks9
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: artaleks9, dmytro-ndp, ibuziuk, svor The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What does this PR do?
or
htpasswd Provider.yaml
needed to configure environmentdevworkspace-test.yaml
needed to create a test workspace:Screenshot/screencast of this PR
What issues does this PR fix or reference?
eclipse-che/che#21753
How to test this PR?
PR Checklist
As the author of this Pull Request I made sure that:
What issues does this PR fix or reference
andHow to test this PR
completedReviewers
Reviewers, please comment how you tested the PR when approving it.