Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update 'che-server' component #39428

Merged
merged 4 commits into from
May 19, 2023

Conversation

artaleks9
Copy link
Contributor

  • Update names of exist tests
  • Add new tests

@openshift-ci openshift-ci bot requested review from dmytro-ndp and tolusha May 17, 2023 14:42
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 17, 2023
@artaleks9
Copy link
Contributor Author

/сс @dmytro-ndp
pinging for review

Copy link
Contributor

@dmytro-ndp dmytro-ndp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to merge

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 18, 2023
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label May 18, 2023
@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@artaleks9: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-eclipse-che-che-server-main-v12-bitbucket-no-pat-oauth-flow eclipse-che/che-server presubmit Presubmit changed
pull-ci-eclipse-che-che-server-main-v12-github-no-pat-oauth-flow eclipse-che/che-server presubmit Presubmit changed
pull-ci-eclipse-che-che-server-main-v12-github-with-pat-setup-flow eclipse-che/che-server presubmit Presubmit changed
pull-ci-eclipse-che-che-server-main-v12-gitlab-no-pat-oauth-flow eclipse-che/che-server presubmit Presubmit changed
pull-ci-eclipse-che-che-server-main-v12-gitlab-with-pat-setup-flow eclipse-che/che-server presubmit Presubmit changed
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 10 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 20 rehearsals
Comment: /pj-rehearse max to run up to 35 rehearsals
Comment: /pj-rehearse auto-ack to run up to 10 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@dmytro-ndp
Copy link
Contributor

/lgtm

@dmytro-ndp
Copy link
Contributor

/pj-rehearse ack

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label May 19, 2023
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 19, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 19, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: artaleks9, dmytro-ndp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 19, 2023

@artaleks9: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 8ee0dcf into openshift:master May 19, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 19, 2023

@artaleks9: Updated the following 2 configmaps:

  • ci-operator-master-configs configmap in namespace ci at cluster app.ci using the following files:
    • key eclipse-che-che-server-main__v12.yaml using file ci-operator/config/eclipse-che/che-server/eclipse-che-che-server-main__v12.yaml
  • job-config-master-presubmits configmap in namespace ci at cluster app.ci using the following files:
    • key eclipse-che-che-server-main-presubmits.yaml using file ci-operator/jobs/eclipse-che/che-server/eclipse-che-che-server-main-presubmits.yaml

In response to this:

  • Update names of exist tests
  • Add new tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants