fix(convert): When converting devfile v1 to v2, registryUrl attribute is forgotten

[benoitf]

What does this PR do?

Devfile v1 is converted internally to devfile V2 to expose new API to plug-ins/extensions but registryUrl field was not handled.
Thus, if the editor needs to write the file at some point, this information is removed

Screenshot/screencast of this PR

What issues does this PR fix or reference?

Fixes eclipse-che/che#19829

How to test this PR?

Look at the unit test (now the field is preserved)

Another manual way : Add a custom component using registryUrl field, then starts the workspace, install another plug-in and now look at the updated devfile. New plug-in should be there but also the registryUrl should be still there

PR Checklist

As the author of this Pull Request I made sure that:

• The Eclipse Contributor Agreement is valid
• Code produced is complete
• Code builds without errors
• Tests are covering the bugfix
• The repository devfile is up to date and works
• Sections What issues does this PR fix or reference and How to test this PR completed
• Relevant user documentation updated
• Relevant contributing documentation updated
• CI/CD changes implemented, documented and communicated

Reviewers

Reviewers, please comment how you tested the PR when approving it.

Happy Path Channel

HAPPY_PATH_CHANNEL=next

Change-Id: Ia7dd9aec31f0c6b5326c4d645bfbf4f87ac8e69e
Signed-off-by: Florent Benoit fbenoit@redhat.com

[che-bot]

❌ E2E Happy path tests failed ❗

See Details

• Jenkins job

• test report

• logs and configs

• Happy path tests DevFile

• images:

name	link
che-theia	quay.io/crw_pr/che-theia:1115
che-theia-endpoint-runtime-binary	quay.io/crw_pr/che-theia-endpoint-runtime-binary:1115

Tested with Eclipse Che on K8S (minikube v1.1.1)

• Use comment "[crw-ci-test]" to rerun happy path E2E test.
• Use comment "[crw-ci-test --rebuild]" to re-build the images and rerun happy path E2E test.

Eclipse Che QE channel: https://mattermost.eclipse.org/eclipse/channels/eclipse-che-qe

[codecov]

Codecov Report

Merging #1115 (1eaf9db) into master (eeb4526) will increase coverage by 2.81%.
The diff coverage is 54.83%.

@@            Coverage Diff             @@
##           master    #1115      +/-   ##
==========================================
+ Coverage   29.45%   32.26%   +2.81%     
==========================================
  Files         277      281       +4     
  Lines        9336     9551     +215     
  Branches     1380     1435      +55     
==========================================
+ Hits         2750     3082     +332     
+ Misses       6487     6373     -114     
+ Partials       99       96       -3     

Impacted Files	Coverage Δ
...theia-about/src/browser/about-che-theia-dialog.tsx	0.00% <ø> (ø)
...e-sync-tracker/src/browser/sync-process-tracker.ts	0.00% <0.00%> (ø)
...ovisioner/src/node/git-configuration-controller.ts	0.00% <0.00%> (ø)
...eia-plugin-remote/src/node/hosted-plugin-remote.ts	0.00% <0.00%> (ø)
...theia-plugin-remote/src/node/plugin-host-custom.ts	0.00% <0.00%> (ø)
...in-remote/src/node/plugin-remote-backend-module.ts	0.00% <0.00%> (ø)
...theia-plugin-remote/src/node/plugin-remote-init.ts	0.00% <0.00%> (ø)
...-che-theia-plugin-remote/src/node/plugin-remote.ts	0.00% <0.00%> (ø)
...ugin-remote/src/node/server-plugin-proxy-runner.ts	0.00% <0.00%> (ø)
...plugin-remote/src/node/terminal-container-aware.ts	0.00% <0.00%> (ø)
... and 68 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b01482c...1eaf9db. Read the comment docs.

[ibuziuk]

would be great to back port it for 7.30.x so that it would land in the 2.9 version of product

[dmytro-ndp]

[crw-ci-test]

[che-bot]

❌ E2E Happy path tests failed ❗

See Details

• Jenkins job

• test report

• logs and configs

• Happy path tests DevFile

• images:

name	link
che-theia	quay.io/crw_pr/che-theia:1115
che-theia-endpoint-runtime-binary	quay.io/crw_pr/che-theia-endpoint-runtime-binary:1115

Tested with Eclipse Che on K8S (minikube v1.1.1)

• Use comment "[crw-ci-test]" to rerun happy path E2E test.
• Use comment "[crw-ci-test --rebuild]" to re-build the images and rerun happy path E2E test.

Eclipse Che QE channel: https://mattermost.eclipse.org/eclipse/channels/eclipse-che-qe

[benoitf]

Happy path worked on ubi8 next

[benoitf]

[crw-ci-test --rebuild]

[che-bot]

❌ E2E Happy path tests failed ❗

See Details

• Jenkins job

• test report

• logs and configs

• Happy path tests DevFile

• images:

name	link
che-theia	quay.io/crw_pr/che-theia:1115
che-theia-endpoint-runtime-binary	quay.io/crw_pr/che-theia-endpoint-runtime-binary:1115

Tested with Eclipse Che on K8S (minikube v1.1.1)

• Use comment "[crw-ci-test]" to rerun happy path E2E test.
• Use comment "[crw-ci-test --rebuild]" to re-build the images and rerun happy path E2E test.

Eclipse Che QE channel: https://mattermost.eclipse.org/eclipse/channels/eclipse-che-qe

[dmytro-ndp]

[crw-ci-test --rebuild]

[che-bot]

❌ E2E Happy path tests failed ❗

See Details

• Jenkins job

• test report

• logs and configs

• Happy path tests DevFile

• images:

name	link
che-theia	quay.io/crw_pr/che-theia:1115
che-theia-endpoint-runtime-binary	quay.io/crw_pr/che-theia-endpoint-runtime-binary:1115

Tested with Eclipse Che on K8S (minikube v1.1.1)

• Use comment "[crw-ci-test]" to rerun happy path E2E test.
• Use comment "[crw-ci-test --rebuild]" to re-build the images and rerun happy path E2E test.

Eclipse Che QE channel: https://mattermost.eclipse.org/eclipse/channels/eclipse-che-qe